Fix review comments

mui · Sep 27, 2023 · c91f973 · c91f973
1 parent 6ce9f78
commit c91f973
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 12 deletions.
diff --git a/packages/mui-base/src/FormControl/index.ts b/packages/mui-base/src/FormControl/index.ts
@@ -8,7 +8,6 @@ export type {
   FormControlRootSlotPropsOverrides,
   FormControlState,
   UseFormControlContextReturnValue,
-  // for material-next
   FormControlOwnProps,
 } from './FormControl.types';
 

diff --git a/packages/mui-material-next/migration.md b/packages/mui-material-next/migration.md
@@ -132,6 +132,17 @@ If you need to prevent default on a `key-up` and/or `key-down` event, then besid
 
 This is to ensure that default is prevented when the `ButtonBase` root is not a native button, for example, when the root element used is a `span`.
 
+## FormControl
+
+### Renamed `FormControlState`
+
+The `FormControlState` interface was renamed to `FormControlContextValue`:
+
+```diff
+-import { FormControlState } from '@mui/material';
++import { FormControlContextValue } from '@mui/material-next';
+```
+
 ## InputBase
 
 ### Removed `inputProps`

diff --git a/packages/mui-material-next/src/FormControl/FormControl.tsx b/packages/mui-material-next/src/FormControl/FormControl.tsx
@@ -28,11 +28,11 @@ const FormControlRoot = styled('div', {
   name: 'MuiFormControl',
   slot: 'Root',
   overridesResolver: ({ ownerState }, styles) => {
-    return {
-      ...(styles.root as Record<string, unknown>),
-      ...(styles[`margin${capitalize(ownerState.margin)}`] as Record<string, unknown>),
-      ...(ownerState.fullWidth && styles.fullWidth),
-    };
+    return [
+      styles.root,
+      styles[`margin${capitalize(ownerState.margin)}`],
+      ownerState.fullWidth && styles.fullWidth,
+    ];
   },
 })<{ ownerState: FormControlOwnerState }>(({ ownerState }) => ({
   display: 'inline-flex',
@@ -87,8 +87,7 @@ const FormControl = React.forwardRef(function FormControl<
   const props = useThemeProps({ props: inProps, name: 'MuiFormControl' });
   const {
     children,
-    className,
-    classes: classesProp,
+    classes: classesProp = {},
     color = 'primary',
     component: componentProp,
     disabled = false,
@@ -182,7 +181,7 @@ const FormControl = React.forwardRef(function FormControl<
 
   const ownerState = {
     ...props,
-    classes: props.classes ?? {},
+    classes: classesProp,
     color,
     component: componentProp,
     disabled,
@@ -252,7 +251,7 @@ const FormControl = React.forwardRef(function FormControl<
       as: componentProp,
     },
     ownerState,
-    className: [classes.root, className],
+    className: classes.root,
   });
 
   return (

diff --git a/packages/mui-material-next/src/FormControl/FormControl.types.ts b/packages/mui-material-next/src/FormControl/FormControl.types.ts
@@ -79,7 +79,7 @@ export type FormControlProps<
   component?: React.ElementType;
 };
 
-type MaterialYouOwnerStateKeys =
+type MaterialDesignOwnerStateKeys =
   | 'classes'
   | 'color'
   | 'margin'
@@ -89,5 +89,5 @@ type MaterialYouOwnerStateKeys =
   | 'variant';
 
 export type FormControlOwnerState = Simplify<
-  Required<Pick<FormControlOwnProps, MaterialYouOwnerStateKeys>> & FormControlProps
+  Required<Pick<FormControlOwnProps, MaterialDesignOwnerStateKeys>> & FormControlProps
 >;