[core] Upgrade eslint (#8583)

mui · Oct 7, 2017 · e66d4c4 · e66d4c4
1 parent 366857b
commit e66d4c4
Show file tree

Hide file tree

Showing 107 changed files with 326 additions and 347 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -28,6 +28,8 @@ module.exports = {
     'linebreak-style': 'off', // Don't play nicely with Windows.
     'arrow-body-style': 'off', // Not our taste?
     'arrow-parens': 'off', // Incompatible with prettier
+    'object-curly-newline': 'off', // Incompatible with prettier
+    'function-paren-newline': 'off', // Incompatible with prettier
     indent: 'off', // Incompatible with prettier
     'space-before-function-paren': 'off', // Incompatible with prettier
     'no-mixed-operators': 'off', // Incompatible with prettier
@@ -46,6 +48,7 @@ module.exports = {
     'no-prototype-builtins': 'off', // airbnb use error
     'object-curly-spacing': 'off', // use babel plugin rule
     'no-restricted-properties': 'off', // To remove once react-docgen support ** operator.
+    'prefer-destructuring': 'off', // To remove once react-docgen support ** operator.
 
     'babel/object-curly-spacing': ['error', 'always'],
 
@@ -88,6 +91,8 @@ module.exports = {
         ],
       },
     ],
+    'react/default-props-match-prop-types': 'off', // Buggy
+    'react/jsx-curly-brace-presence': 'off', // Buggy
 
     'material-ui/docgen-ignore-before-comment': 'error',
 

diff --git a/docs/src/modules/components/AppWrapper.js b/docs/src/modules/components/AppWrapper.js
@@ -43,7 +43,7 @@ class AppWrapper extends React.Component<any, any> {
     // Wait for the title to be updated.
     this.googleTimer = setTimeout(() => {
       window.gtag('config', config.google.id, {
-        page_path: location.pathname,
+        page_path: window.location.pathname,
       });
     });
   }

diff --git a/docs/src/pages/.eslintrc.js b/docs/src/pages/.eslintrc.js
@@ -0,0 +1,5 @@
+module.exports = {
+  rules: {
+    'prefer-destructuring': 'error',
+  },
+};
diff --git a/docs/src/pages/customization/CssInJs.js b/docs/src/pages/customization/CssInJs.js
@@ -52,7 +52,7 @@ const MyLinkStyled = withStyles(styles)(MyLink);
 export default function CssInJs() {
   return (
     <Typography type="subheading">
-      <MyLinkStyled href="#">{'MyLink'}</MyLinkStyled>
+      <MyLinkStyled href="#">MyLink</MyLinkStyled>
       {' - '}
       <MyLinkStyled href="#" variant="primary">
         {'primary'}

diff --git a/docs/src/pages/customization/OverridesComponent.js b/docs/src/pages/customization/OverridesComponent.js
@@ -5,7 +5,7 @@ import OverridesClassNames from 'docs/src/pages/customization/OverridesClassName
 
 // We can use OverridesClassNames over and over.
 function OverridesComponent() {
-  return <OverridesClassNames>{'Component'}</OverridesClassNames>;
+  return <OverridesClassNames>Component</OverridesClassNames>;
 }
 
 export default OverridesComponent;
diff --git a/docs/src/pages/customization/OverridesInlineStyle.js b/docs/src/pages/customization/OverridesInlineStyle.js
@@ -15,7 +15,7 @@ const style = {
 };
 
 function OverridesInlineStyle() {
-  return <Button style={style}>{'inline-style'}</Button>;
+  return <Button style={style}>inline-style</Button>;
 }
 
 export default OverridesInlineStyle;
diff --git a/docs/src/pages/customization/OverridesTheme.js b/docs/src/pages/customization/OverridesTheme.js
@@ -25,7 +25,7 @@ const theme = createMuiTheme({
 function OverridesTheme() {
   return (
     <MuiThemeProvider theme={theme}>
-      <Button>{'Overrides'}</Button>
+      <Button>Overrides</Button>
     </MuiThemeProvider>
   );
 }

diff --git a/docs/src/pages/customization/Palette.js b/docs/src/pages/customization/Palette.js
@@ -22,8 +22,8 @@ function Palette() {
   return (
     <MuiThemeProvider theme={theme}>
       <div>
-        <Button color="primary">{'Primary'}</Button>
-        <Button color="accent">{'Accent'}</Button>
+        <Button color="primary">Primary</Button>
+        <Button color="accent">Accent</Button>
       </div>
     </MuiThemeProvider>
   );

diff --git a/docs/src/pages/customization/TypographyTheme.js b/docs/src/pages/customization/TypographyTheme.js
@@ -25,8 +25,8 @@ function TypographyTheme() {
   return (
     <MuiThemeProvider theme={theme}>
       <div>
-        <Typography type="body1">{'body1'}</Typography>
-        <Button>{'Button'}</Button>
+        <Typography type="body1">body1</Typography>
+        <Button>Button</Button>
       </div>
     </MuiThemeProvider>
   );

diff --git a/docs/src/pages/demos/app-bar/ButtonAppBar.js b/docs/src/pages/demos/app-bar/ButtonAppBar.js
@@ -25,7 +25,7 @@ const styles = theme => ({
 });
 
 function ButtonAppBar(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div className={classes.root}>
       <AppBar position="static">

diff --git a/docs/src/pages/demos/app-bar/SimpleAppBar.js b/docs/src/pages/demos/app-bar/SimpleAppBar.js
@@ -15,7 +15,7 @@ const styles = theme => ({
 });
 
 function SimpleAppBar(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div className={classes.root}>
       <AppBar position="static" color="default">

diff --git a/docs/src/pages/demos/avatars/IconAvatars.js b/docs/src/pages/demos/avatars/IconAvatars.js
@@ -31,7 +31,7 @@ const styles = {
 };
 
 function IconAvatars(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div className={classes.row}>
       <Avatar className={classes.avatar}>

diff --git a/docs/src/pages/demos/avatars/ImageAvatars.js b/docs/src/pages/demos/avatars/ImageAvatars.js
@@ -21,7 +21,7 @@ const styles = {
 };
 
 function ImageAvatars(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div className={classes.row}>
       <Avatar alt="Remy Sharp" src="/static/images/remy.jpg" className={classes.avatar} />

diff --git a/docs/src/pages/demos/avatars/LetterAvatars.js b/docs/src/pages/demos/avatars/LetterAvatars.js
@@ -28,7 +28,7 @@ const styles = {
 };
 
 function LetterAvatars(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div className={classes.row}>
       <Avatar className={classes.avatar}>H</Avatar>

diff --git a/docs/src/pages/demos/badges/SimpleBadge.js b/docs/src/pages/demos/badges/SimpleBadge.js
@@ -14,7 +14,7 @@ const styles = theme => ({
 });
 
 function SimpleBadge(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div>
       <Badge className={classes.badge} badgeContent={4} color="primary">

diff --git a/docs/src/pages/demos/bottom-navigation/LabelBottomNavigation.js b/docs/src/pages/demos/bottom-navigation/LabelBottomNavigation.js
@@ -25,7 +25,7 @@ class LabelBottomNavigation extends React.Component {
   };
 
   render() {
-    const classes = this.props.classes;
+    const { classes } = this.props;
     const { value } = this.state;
 
     return (

diff --git a/docs/src/pages/demos/bottom-navigation/SimpleBottomNavigation.js b/docs/src/pages/demos/bottom-navigation/SimpleBottomNavigation.js
@@ -24,7 +24,7 @@ class SimpleBottomNavigation extends React.Component {
   };
 
   render() {
-    const classes = this.props.classes;
+    const { classes } = this.props;
     const { value } = this.state;
 
     return (

diff --git a/docs/src/pages/demos/buttons/FlatButtons.js b/docs/src/pages/demos/buttons/FlatButtons.js
@@ -18,7 +18,7 @@ function doSomething(event) {
 }
 
 function FlatButtons(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div>
       <Button className={classes.button}>Default</Button>

diff --git a/docs/src/pages/demos/buttons/FloatingActionButtons.js b/docs/src/pages/demos/buttons/FloatingActionButtons.js
@@ -14,7 +14,7 @@ const styles = theme => ({
 });
 
 function FloatingActionButtons(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div>
       <Button fab color="primary" aria-label="add" className={classes.button}>

diff --git a/docs/src/pages/demos/buttons/IconButtons.js b/docs/src/pages/demos/buttons/IconButtons.js
@@ -15,7 +15,7 @@ const styles = theme => ({
 });
 
 function IconButtons(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div>
       <IconButton className={classes.button} aria-label="Delete">

diff --git a/docs/src/pages/demos/buttons/RaisedButtons.js b/docs/src/pages/demos/buttons/RaisedButtons.js
@@ -15,7 +15,7 @@ const styles = theme => ({
 });
 
 function RaisedButtons(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div>
       <Button raised className={classes.button}>

diff --git a/docs/src/pages/demos/cards/MediaControlCard.js b/docs/src/pages/demos/cards/MediaControlCard.js
@@ -38,7 +38,7 @@ const styles = theme => ({
 });
 
 function MediaControlCard(props) {
-  const classes = props.classes;
+  const { classes } = props;
 
   return (
     <div>

diff --git a/docs/src/pages/demos/cards/RecipeReviewCard.js b/docs/src/pages/demos/cards/RecipeReviewCard.js
@@ -46,7 +46,7 @@ class RecipeReviewCard extends React.Component {
   };
 
   render() {
-    const classes = this.props.classes;
+    const { classes } = this.props;
 
     return (
       <div>

diff --git a/docs/src/pages/demos/cards/SimpleCard.js b/docs/src/pages/demos/cards/SimpleCard.js
@@ -28,7 +28,7 @@ const styles = theme => ({
 });
 
 function SimpleCard(props) {
-  const classes = props.classes;
+  const { classes } = props;
   const bull = <span className={classes.bullet}>•</span>;
 
   return (

diff --git a/docs/src/pages/demos/cards/SimpleMediaCard.js b/docs/src/pages/demos/cards/SimpleMediaCard.js
@@ -17,7 +17,7 @@ const styles = {
 };
 
 function SimpleMediaCard(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div>
       <Card className={classes.card}>

diff --git a/docs/src/pages/demos/chips/Chips.js b/docs/src/pages/demos/chips/Chips.js
@@ -32,7 +32,7 @@ function handleClick() {
 }
 
 function Chips(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <div className={classes.row}>
       <Chip label="Basic Chip" className={classes.chip} />

diff --git a/docs/src/pages/demos/chips/ChipsArray.js b/docs/src/pages/demos/chips/ChipsArray.js
@@ -50,7 +50,7 @@ class ChipsArray extends React.Component {
   };
 
   render() {
-    const classes = this.props.classes;
+    const { classes } = this.props;
 
     return (
       <div className={classes.row}>

diff --git a/docs/src/pages/demos/dialogs/ConfirmationDialog.js b/docs/src/pages/demos/dialogs/ConfirmationDialog.js
@@ -120,23 +120,22 @@ const styles = theme => ({
 
 class ConfirmationDialogDemo extends React.Component {
   state = {
-    anchorEl: null,
     open: false,
     value: 'Dione',
   };
 
   button = undefined;
 
-  handleClickListItem = event => {
-    this.setState({ open: true, anchorEl: event.currentTarget });
+  handleClickListItem = () => {
+    this.setState({ open: true });
   };
 
   handleRequestClose = value => {
     this.setState({ value, open: false });
   };
 
   render() {
-    const classes = this.props.classes;
+    const { classes } = this.props;
     return (
       <div className={classes.root}>
         <List>

diff --git a/docs/src/pages/demos/dialogs/FormDialog.js b/docs/src/pages/demos/dialogs/FormDialog.js
@@ -28,7 +28,7 @@ export default class FormDialog extends React.Component {
       <div>
         <Button onClick={this.handleClickOpen}>Open form dialog</Button>
         <Dialog open={this.state.open} onRequestClose={this.handleRequestClose}>
-          <DialogTitle>{'Subscribe'}</DialogTitle>
+          <DialogTitle>Subscribe</DialogTitle>
           <DialogContent>
             <DialogContentText>
               To subscribe to this website, please enter your email address here. We will send

diff --git a/docs/src/pages/demos/dividers/InsetDividers.js b/docs/src/pages/demos/dividers/InsetDividers.js
@@ -18,7 +18,7 @@ const styles = theme => ({
 });
 
 function InsetDividers(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <List className={classes.root}>
       <ListItem button>

diff --git a/docs/src/pages/demos/dividers/ListDividers.js b/docs/src/pages/demos/dividers/ListDividers.js
@@ -15,7 +15,7 @@ const styles = theme => ({
 });
 
 function ListDividers(props) {
-  const classes = props.classes;
+  const { classes } = props;
   return (
     <List className={classes.root}>
       <ListItem button>

diff --git a/docs/src/pages/demos/drawers/MiniDrawer.js b/docs/src/pages/demos/drawers/MiniDrawer.js
@@ -110,7 +110,7 @@ class MiniDrawer extends React.Component {
   };
 
   render() {
-    const classes = this.props.classes;
+    const { classes } = this.props;
 
     return (
       <div className={classes.root}>

diff --git a/docs/src/pages/demos/drawers/TemporaryDrawer.js b/docs/src/pages/demos/drawers/TemporaryDrawer.js
@@ -33,7 +33,7 @@ class TemporaryDrawer extends React.Component {
   };
 
   render() {
-    const classes = this.props.classes;
+    const { classes } = this.props;
 
     const sideList = (
       <div className={classes.list}>
@@ -58,12 +58,22 @@ class TemporaryDrawer extends React.Component {
         <Button onClick={this.toggleDrawer('top', true)}>Open Top</Button>
         <Button onClick={this.toggleDrawer('bottom', true)}>Open Bottom</Button>
         <Drawer open={this.state.left} onRequestClose={this.toggleDrawer('left', false)}>
-          <div tabIndex={0} role="button" onClick={this.toggleDrawer('left', false)}>
+          <div
+            tabIndex={0}
+            role="button"
+            onClick={this.toggleDrawer('left', false)}
+            onKeyDown={this.toggleDrawer('left', false)}
+          >
             {sideList}
           </div>
         </Drawer>
         <Drawer anchor="top" open={this.state.top} onRequestClose={this.toggleDrawer('top', false)}>
-          <div tabIndex={0} role="button" onClick={this.toggleDrawer('top', false)}>
+          <div
+            tabIndex={0}
+            role="button"
+            onClick={this.toggleDrawer('top', false)}
+            onKeyDown={this.toggleDrawer('top', false)}
+          >
             {fullList}
           </div>
         </Drawer>
@@ -72,7 +82,12 @@ class TemporaryDrawer extends React.Component {
           open={this.state.bottom}
           onRequestClose={this.toggleDrawer('bottom', false)}
         >
-          <div tabIndex={0} role="button" onClick={this.toggleDrawer('bottom', false)}>
+          <div
+            tabIndex={0}
+            role="button"
+            onClick={this.toggleDrawer('bottom', false)}
+            onKeyDown={this.toggleDrawer('bottom', false)}
+          >
             {fullList}
           </div>
         </Drawer>
@@ -81,7 +96,12 @@ class TemporaryDrawer extends React.Component {
           open={this.state.right}
           onRequestClose={this.toggleDrawer('right', false)}
         >
-          <div tabIndex={0} role="button" onClick={this.toggleDrawer('right', false)}>
+          <div
+            tabIndex={0}
+            role="button"
+            onClick={this.toggleDrawer('right', false)}
+            onKeyDown={this.toggleDrawer('right', false)}
+          >
             {sideList}
           </div>
         </Drawer>

diff --git a/docs/src/pages/demos/grid-list/AdvancedGridList.js b/docs/src/pages/demos/grid-list/AdvancedGridList.js
@@ -48,7 +48,7 @@ const styles = theme => ({
  * ];
  */
 function AdvancedGridList(props) {
-  const classes = props.classes;
+  const { classes } = props;
 
   return (
     <div className={classes.root}>