-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SpeedDial] SpeedDialAction visibility is poor on dark themes #10763
Labels
bug 🐛
Something doesn't work
component: speed dial
This is the name of the generic UI component, not the React module!
Comments
oliviertassinari
added
package: lab
Specific to @mui/lab
component: speed dial
This is the name of the generic UI component, not the React module!
labels
Mar 22, 2018
@RyanFields You're quite right. Would you like to try and improve it? |
@mbrookes Started looking into a fix, but I need to spend time familiarizing myself with Material-UI's structure and inner workings. This is the first time I've tried working with the code. I will circle back to this in a couple weeks. |
Thanks. Shout if you need any help. 📢 |
mbrookes
added a commit
that referenced
this issue
Jul 21, 2018
Also improve some button class descriptions. Closes #10763 <!-- Thanks so much for your PR, your contribution is appreciated! ❤️ --> ![image](https://user-images.githubusercontent.com/357702/43039919-44fe59ee-8d2f-11e8-95c5-937b4ea6a426.png)
this issue is reproducing with same steps again |
oliviertassinari
changed the title
SpeedDialAction visibility is poor on dark themes
[SpeedDial] SpeedDialAction visibility is poor on dark themes
Jan 9, 2021
oliviertassinari
added
bug 🐛
Something doesn't work
and removed
package: lab
Specific to @mui/lab
labels
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: speed dial
This is the name of the generic UI component, not the React module!
The icon and button colors on SpeedDialActions have weak visibility on dark themes. This can be seen on the material-ui site itself by switching to the dark theme and viewing the SpeedDial demo.
Expected Behavior
SpeedDialAction should use a darker button color in themes where palette type is set to "dark".
Current Behavior
SpeedDialAction buttons are displayed with a white icon on a light background when palette type is set to "dark", making the icon difficult to see.
Steps to Reproduce (for bugs)
Context
Just experimenting with SpeedDial in my app and noticing that the action buttons are hard to differentiate on my app's dark theme.
Your Environment
The text was updated successfully, but these errors were encountered: