Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons on Icon Buttons get shifted on Safari 10 #12271

Closed
2 tasks done
KevinAsher opened this issue Jul 25, 2018 · 2 comments
Closed
2 tasks done

Icons on Icon Buttons get shifted on Safari 10 #12271

KevinAsher opened this issue Jul 25, 2018 · 2 comments
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@KevinAsher
Copy link
Contributor

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Icon buttons get displayed correctly on Safari

Current Behavior

The icons get shifted to the left:

37716483_2033581546666491_8232487326064836608_n

Your Environment

Tech Version
browser Safari 10.0
OS iOS 10.3.3
@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Jul 25, 2018
@oliviertassinari
Copy link
Member

@KevinAsher Thanks for the repoort! We need to add this style back with a comment:
https://github.com/mui-org/material-ui/pull/11941/files#diff-f1c2e2febb0dbd2116e5daaf2a51958cL40
Do you want to work on it? :)

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! labels Jul 25, 2018
@KevinAsher
Copy link
Contributor Author

KevinAsher commented Jul 25, 2018 •
edited
Loading

Sure! As soon i get some time from work today i'll add it, thanks.

@KevinAsher KevinAsher mentioned this issue Jul 25, 2018
Merged
oliviertassinari pushed a commit that referenced this issue Jul 25, 2018
@KevinAsher @oliviertassinari
[Button] Fix icon positioning (#12278)
245f973 
Closes #12271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @KevinAsher