-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/modifications request #1335
Labels
new feature
New feature or request
Comments
+1 on dividers |
+1 for optional |
I agree, avatar should be optional. How are other people working round this? This is what I do but euurghh:
|
We had a first attempt some time ago #1879. |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First off, I think sub-elements like
<CardHeader/>
should have a sub header, with documentation in the menu at: http://material-ui.com/#/components/cardsAnd,
CardHeader
should have theavatar
as an optional option, so when not specified, not render avatar at all.Secondly I'd argue that perhaps the
Card
element doesn't need a specialCardText
and could use a general purpose<Text />
element. Wich brings me to the third point:I hope the material elements list: https://www.google.com/design/spec/components/bottom-sheets.html doesn't get translated too literally, although we probably need each one of them, we should also have available basic elements like
Title
orHeader
with a size prop and perhaps alignment left/right.And I think basic things like
Dividers
should have a high priority (https://www.google.com/design/spec/components/dividers.html)And I hope a grid system will be made like: https://www.google.com/design/spec/components/grid-lists.html#grid-lists-specs which will be flexible and composable enough to use without images or have some more creative freedom to make your own stuff, based on material design, not limited by it.
As for the rest, awesome work, and I'm curious to see how this project will evolve and who will find an ingenious way to implement the motion principles from MD, like pressing a floating button would zoom it in circularly into a CardMedia Header thing, or something like that... (Probably involving cloning some elements)
The text was updated successfully, but these errors were encountered: