[CardHeader] Make avatar prop optional #1879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CardHeader shouldn't be required to have an Avatar. The avatar should be blank if no prop is assigned.
sjstebbins
changed the title
sjstebbins
changed the title
| @@ -94,14 +94,15 @@ const CardHeader = React.createClass({ | |||
| let titleStyle = this.prepareStyles(styles.title, this.props.titleStyle); | |||
| let subtitleStyle = this.prepareStyles(styles.subtitle, this.props.subtitleStyle); | |||
|
|
|||
| let avatar = this.props.avatar; | |||
| let avatar = this.props.avatar || null; | |||
There was a problem hiding this comment.
I think it's better to use the getDefaultProps
There was a problem hiding this comment.
What if you don't set a default at all and just check on line 102 for
else if (typeof this.props.avatar === 'string') {
Seems to express the intention of the if-statement better, imo.
There was a problem hiding this comment.
@oliviertassinari did you have more feedback for @thataustin ?
oliviertassinari
added
the
PR: needs revision
Closed
|
This is resolved by #2397. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CardHeader shouldn't be required to have an Avatar. The avatar should be blank if no prop is assigned.