Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ListItem] props 'alignItems' is not existed in d.ts #14331

Closed
2 tasks done
kanufy opened this issue Jan 29, 2019 · 1 comment
Closed
2 tasks done

[ListItem] props 'alignItems' is not existed in d.ts #14331

kanufy opened this issue Jan 29, 2019 · 1 comment
Labels
good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@kanufy
Copy link

kanufy commented Jan 29, 2019

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

<ListItem alignItems={'flex-start'}>

Current Behavior 😯

alignItems is written in API document.
https://material-ui.com/api/list-item/#props

But this props is not existed in ListItem.d.ts.
https://github.com/mui-org/material-ui/blob/0e4d0590283d40663d04b6b1a902b974bd79227b/packages/material-ui/src/ListItem/ListItem.d.ts#L5-L21

Your Environment 🌎

Tech Version
Material-UI v3.9.1
React v16.7.0
Browser Chrome 71.0
TypeScript v3.2.4
@eps1lon eps1lon added good first issue Great for first contributions. Enable to learn the contribution process. typescript labels Jan 29, 2019
@eps1lon
Copy link
Member

eps1lon commented Jan 29, 2019

PRs welcome that match the propTypes definition in
https://github.com/mui-org/material-ui/blob/578ba6ec1b5a90a27c140b62ffb1248fc4f71672/packages/material-ui/src/ListItem/ListItem.js#L176

@EndiM EndiM mentioned this issue Jan 29, 2019
Merged
1 task
eps1lon pushed a commit that referenced this issue Jan 30, 2019
@EndiM @eps1lon
[ListItem] Add alignItems prop to ListItem.d.ts (#14334)
9379bf8 
Closes #14331

* [ListItem] add alignItems prop to ListItem.d.ts

* sort alpha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kanufy @eps1lon