Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ButtonProps className make SpeedDial unclickable #15651

Closed
2 tasks done
janhesters opened this issue May 10, 2019 · 10 comments · Fixed by #15652
Closed
2 tasks done

ButtonProps className make SpeedDial unclickable #15651

janhesters opened this issue May 10, 2019 · 10 comments · Fixed by #15652
Assignees
@oliviertassinari
Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module!

Comments

@janhesters
Copy link
Contributor

janhesters commented May 10, 2019 •
edited
Loading

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

The button should get the class and still work.

Current Behavior 😯

It is unclickable (and in general all on<event> methods won't work).

Steps to Reproduce 🕹

Link: https://codesandbox.io/s/xon8qz939p

  1. Give speed dial ButtonProps: {{ className: 'something' }}

Context 🔦

I was giving it a class to apply custom styles.

Your Environment 🌎

Tech Version
Material-UI v4.0.0-beta.1
React 16.8.6
Browser Chrome
TypeScript None
etc.
@oliviertassinari oliviertassinari added the component: speed dial This is the name of the generic UI component, not the React module! label May 10, 2019
@oliviertassinari

This comment has been minimized.

Sign in to view
@janhesters

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@janhesters
Copy link
Contributor Author

@oliviertassinari That is sad to hear. I think it would get more usage once it's merged in core, but I'm biased 😄

Are you interested in reproducing the same fix? :)

Yep! I'm gonna do a quick PR.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 10, 2019
@janhesters
Copy link
Contributor Author

Here is the PR: #15652

@oliviertassinari oliviertassinari self-assigned this May 10, 2019
@janhesters janhesters mentioned this issue May 10, 2019
Merged
@mbrookes

This comment has been minimized.

Sign in to view
@janhesters janhesters changed the title ButtonProps className make SpeedDial unusable ButtonProps className make SpeedDial unclickable May 10, 2019
@janhesters

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@hburrows

This comment has been minimized.

Sign in to view
@mbrookes
Copy link
Member

@hburrows Thanks. I'll mark the "future of SpeedDial" comments as off-topic to keep this issue on-point. We can open a new issue for this if it warrants further discussion on the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SpeedDial] Fix classname override logic
4 participants
@mbrookes @hburrows @oliviertassinari @janhesters