Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeedDial] Fix classname override logic #15652

Merged
merged 2 commits into from
May 10, 2019
Merged

[SpeedDial] Fix classname override logic #15652

merged 2 commits into from
May 10, 2019

Conversation

janhesters
Copy link
Contributor

@janhesters janhesters commented May 10, 2019 •
edited by oliviertassinari
Loading

Closes #15651

@janhesters janhesters mentioned this pull request May 10, 2019
Closed
2 tasks
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module! labels May 10, 2019
@oliviertassinari oliviertassinari changed the title Fix classname for Fab button. [SpeedDialog] Fix classname override logic May 10, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented May 10, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 6ef44f1...747a361

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 311,022 311,022 84,579 84,579
@material-ui/core/Paper 0.00% 0.00% 67,623 67,623 20,121 20,121
@material-ui/core/Paper.esm 0.00% 0.00% 60,988 60,988 19,018 19,018
@material-ui/core/Popper 0.00% 0.00% 31,114 31,114 10,805 10,805
@material-ui/core/Textarea 0.00% 0.00% 5,468 5,468 2,364 2,364
@material-ui/core/TrapFocus 0.00% 0.00% 3,731 3,731 1,565 1,565
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,943 15,943 5,777 5,777
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 974 974
@material-ui/lab +0.02% 🔺 0.00% 140,444 140,475 42,608 42,609
@material-ui/styles 0.00% 0.00% 51,151 51,151 15,149 15,149
@material-ui/system 0.00% 0.00% 11,765 11,765 3,923 3,923
Button 0.00% 0.00% 85,266 85,266 25,677 25,677
Modal 0.00% 0.00% 20,575 20,575 6,601 6,601
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 51,486 51,486 11,342 11,342
docs.main 0.00% 0.00% 648,437 648,437 202,322 202,322
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 292,788 292,788 82,538 82,538

Generated by 🚫 dangerJS against 747a361

@mbrookes mbrookes changed the title [SpeedDialog] Fix classname override logic [SpeedDial] Fix classname override logic May 10, 2019
@oliviertassinari oliviertassinari merged commit f86c992 into mui:next May 10, 2019
@oliviertassinari
Copy link
Member

@janhesters Thanks for the care of our SpeedDial!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ButtonProps className make SpeedDial unclickable
3 participants
@janhesters @mui-pr-bot @oliviertassinari