Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Non-ssr languages dillute search results #17459

Closed
eps1lon opened this issue Sep 17, 2019 · 7 comments
Closed

[docs] Non-ssr languages dillute search results #17459

eps1lon opened this issue Sep 17, 2019 · 7 comments
Labels
docs Improvements or additions to the documentation

Comments

@eps1lon
Copy link
Member

eps1lon commented Sep 17, 2019

Since those languages are only not-ssr for a couple of days (as a result of #17249) duckduckgo might not have caught up already.

I have some ideas that should improve the build times. In the end the it might make more sense to just throw some more CPUs at the build.
@eps1lon eps1lon added the docs Improvements or additions to the documentation label Sep 17, 2019
@oliviertassinari
Copy link
Member

I thought that #17311 was taking care of the issue, but we might have another problem.

@eps1lon
Copy link
Member Author

eps1lon commented Sep 17, 2019

That PR does not explain anything so I can't know what issue it was trying to solve.

Let's observe this for a few days and see if the issue persists.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 17, 2019 •
edited
Loading

That PR does not explain anything so I can't know what issue it was trying to solve.

Yes, sorry. The real fix is here: https://github.com/mui-org/material-ui/pull/17311/files#diff-91b13573960dbcd4bca6832a4bdc9593R67. We have been linking, for a week, invalid alternate language URLs.

Let's observe this for a few days and see if the issue persists.

Agree! Changes in the Google index takes weeks to manifest. We might need another a week or two to see the stable state.

@oliviertassinari
Copy link
Member

It took some time, but Google indexes are finally up-to-date :). I have tested the "material-ui.com icons" from FR and US, no more duplication.

@eps1lon
Copy link
Member Author

eps1lon commented Nov 3, 2019

It took some time, but Google indexes are finally up-to-date :). I have tested the "material-ui.com icons" from FR and US, no more duplication.

It's a bit weird though how they are grouped:

Screenshot from 2019-11-03 19-15-22

material-icons is listed within components/icons and next to the other languages

@oliviertassinari
Copy link
Member

Yeah, I agree, it's strange! I hope it will resolve itself too.

@oliviertassinari
Copy link
Member

It took some time 🙃

Capture d’écran 2019-12-11 à 12 21 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @eps1lon