[docs] Only server-side render the popular languages #17249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 98f2c7c...3d5e1cc
|
oliviertassinari
force-pushed
the
fix-netlify-deploy
branch
9 times, most recently
from
588b023 to
0f9017c
Compare
oliviertassinari
force-pushed
the
fix-netlify-deploy
branch
from
0f9017c to
125686e
Compare
oliviertassinari
changed the title
docs/next.config.js
Outdated
| traverse(pages, userLanguage); | ||
| }); | ||
| } | ||
| // if (process.env.PULL_REQUEST === 'true') { |
There was a problem hiding this comment.
To uncomment before merging.
| const { t } = useSelector(state => ({ | ||
| t: state.options.t, | ||
| })); | ||
| const t = useSelector(state => state.options.t); |
There was a problem hiding this comment.
Note for self, it's what happens when you work on something without internet to verify it's optimal.
useSelector() uses strict === reference equality checks by default, not shallow equality (see the following section for more details).
| } | ||
| } | ||
|
|
||
| function AppWrapper(props) { |
There was a problem hiding this comment.
Inline the file directly into _app.js. As long as the file is less than 1k LOCs (~400 here), we should be fine.
oliviertassinari
force-pushed
the
fix-netlify-deploy
branch
from
125686e to
72d5596
Compare
|
Interesting, Next.js was using, for the static export, 7 threads and 10 of concurrency for a single CPU. This wasn't working well (5 pages/s), reducing to 3 threads and 5 of concurrency helps (10 pages/s). |
mbrookes
approved these changes
Aug 31, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify deploy is broken, the build is too slow. We have 15 minutes and 1 CPU to do all the work.
Maybe we should build on CircleCI and have Netlify deploy the output, to consider in the future 😁.
We can deploy the documentation for v4.4.0 live once this is merged.