[DropDownMenu] buggy value prop check

[yulric]

Hi there,
When I use a SelectField component it looks like the value prop is ignored and the selectedIndex prop is used to set the DropdownMenu text. If this is the default functionality then the docs need to be updated.

Thanks,
Yulric

[shaurya947]

I think you're right @yulric. The value prop means anything only for the text-field component it seems. Would you like to write a PR to update the docs?

[yulric]

Actually, sorry it's just a bug in the code. If you look at https://github.com/callemall/material-ui/blob/master/src/drop-down-menu.jsx#L185, we don't check if it is defined meaning that if we pass a value prop with a value of 0 (which is what I was doing) then it then doesn't go through the code which sets the value of selectedIndex, which is why I assumed that the value prop wasn't working. Sorry about that.

[shaurya947]

Ah I missed that too. If 0 is a valid value then perhaps we should modify the if check there?

[yulric]

yeah I think it should be

if(value !== null && value !== undefined)

[shaurya947]

PR welcome! :-)

[yulric]

Cool, I'll get one in by tonight I think.

[yulric]

Fixed in PR #1768