Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger horizontal padding for small size button #17634

Closed
1 task done
lcswillems opened this issue Sep 30, 2019 · 8 comments · Fixed by #17640
Closed
1 task done

Bigger horizontal padding for small size button #17634

lcswillems opened this issue Sep 30, 2019 · 8 comments · Fixed by #17640
Labels
component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@lcswillems
Copy link
Contributor

lcswillems commented Sep 30, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

The padding of the small size button is : 4px 8px. It doesn't look good to my eyes:

image

The horizontal padding is too small from my point of view. I would prefer something like 4px 11px.

2 arguments:

  • Google uses this kind of padding for their small button on their home page:
    image
  • The medium size button has not the same padding ratio. It is 6/16 = 0.375 (which looks good to my eyes) whereas the small button 4/8 = 1/2 (which doesn't).
@eps1lon eps1lon added the component: button This is the name of the generic UI component, not the React module! label Sep 30, 2019
@eps1lon
Copy link
Member

eps1lon commented Sep 30, 2019

It uses 12px for the horizontal padding for me. Don't have a strong opinion about this. I guess official google pages are the closest we get without having material guidelines.

@lcswillems
Copy link
Contributor Author

I proposed 11px because 4 * 16/6 = 11 (to keep the same ratio) but 12px would be good for me

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 30, 2019

@lcswillems Interesting concern, it seems that our small button demo is "skewed" by the min-width property that takes precedence over the default padding. We can use https://vuetifyjs.com/en/components/buttons#examples to benchmark against.

What do you think of 10px instead of 8px?

@lcswillems
Copy link
Contributor Author

10px is fine also!

@oliviertassinari
Copy link
Member

Great, unless somebody raises a concern about the change, we would be happy to accept a pull request :)

@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Sep 30, 2019
@lcswillems
Copy link
Contributor Author

lcswillems commented Sep 30, 2019

I am sorry but I won't take the time to do a pull request for this. I will have to clone the repo, take time to find where to modify it (because I don't know the code base), do the pull request etc..., just to replace "8px" by "10px", whereas in your case, in one small commit it can be done.

I hope that you understand it.

Anyway, thank you for all your work and for having taking the time to answer me. As I said in a previous issue, I really enjoy your work and think it highly impacts web development today!!

@ubaidisaev
Copy link

I made a pull request

@lcswillems
Copy link
Contributor Author

Okay thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
4 participants