-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigger horizontal padding for small size button #17634
Comments
It uses 12px for the horizontal padding for me. Don't have a strong opinion about this. I guess official google pages are the closest we get without having material guidelines. |
I proposed 11px because |
@lcswillems Interesting concern, it seems that our small button demo is "skewed" by the min-width property that takes precedence over the default padding. We can use https://vuetifyjs.com/en/components/buttons#examples to benchmark against. What do you think of 10px instead of 8px? |
|
Great, unless somebody raises a concern about the change, we would be happy to accept a pull request :) |
I am sorry but I won't take the time to do a pull request for this. I will have to clone the repo, take time to find where to modify it (because I don't know the code base), do the pull request etc..., just to replace "8px" by "10px", whereas in your case, in one small commit it can be done. I hope that you understand it. Anyway, thank you for all your work and for having taking the time to answer me. As I said in a previous issue, I really enjoy your work and think it highly impacts web development today!! |
I made a pull request |
Okay thank you! |
Closes mui#17634
Summary 💡
The padding of the small size button is :
4px 8px
. It doesn't look good to my eyes:The horizontal padding is too small from my point of view. I would prefer something like
4px 11px
.2 arguments:
6/16 = 0.375
(which looks good to my eyes) whereas the small button4/8 = 1/2
(which doesn't).The text was updated successfully, but these errors were encountered: