React 0.14 - Card throw

[cgestes]

Uncaught TypeError: Can't add property onTouchTap, object is not extensible card.jsx:46

in code:

  if (currentChild.props.actAsExpander === true) {
    currentChild.props.onTouchTap = this._onExpandable;
    currentChild.props.style = this.mergeStyles({ cursor: 'pointer' }, currentChild.props.style);
  }

[cgestes]

@hugo-agbonon

[cgestes]

dont know if this fail also on master. (I'am working on react-0.14-support). But I'am pretty the fix will work on both branch.

[codeheroics]

I don't think it fails on the master (the docs website is still OK, both online and when I build it), but yeah, sorry, I hadn't tried this at all with react 0.14.
I think words are missing from from your last sentence, are you saying you already have a fix (or fix idea) for 0.14 support?

[cgestes]

No fix from my side, I guess it's not possible anymore to modify child in
react they must be cloned. I had no time to look at the issue atm

On Tue, Oct 13, 2015, 19:41 Hugo Agbonon notifications@github.com wrote:

I don't think it fails on the master (the docs website is still OK, both
online and when I build it), but yeah, sorry, I hadn't tried this at all
with react 0.14.
I think words are missing from from your last sentence, are you saying you
already have a fix (or fix idea) for 0.14 support?

—
Reply to this email directly or view it on GitHub
#1868 (comment)
.

[cgestes]

Fixed. Will send a PR later on tonight

On Tue, Oct 13, 2015, 20:24 Cedric GESTES cedric.gestes@gmail.com wrote:

No fix from my side, I guess it's not possible anymore to modify child in
react they must be cloned. I had no time to look at the issue atm

On Tue, Oct 13, 2015, 19:41 Hugo Agbonon notifications@github.com wrote:

I don't think it fails on the master (the docs website is still OK, both
online and when I build it), but yeah, sorry, I hadn't tried this at all
with react 0.14.
I think words are missing from from your last sentence, are you saying
you already have a fix (or fix idea) for 0.14 support?

—
Reply to this email directly or view it on GitHub
#1868 (comment)
.