Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too much repetition in components (muiTheme in state & context) #1941

Closed
louy opened this issue Oct 20, 2015 · 1 comment
Closed

Too much repetition in components (muiTheme in state & context) #1941

louy opened this issue Oct 20, 2015 · 1 comment
Labels
core Infrastructure work going on behind the scenes customization: css Design CSS customizability

Comments

@louy
Copy link
Contributor

louy commented Oct 20, 2015

So apparently we have too much repeated code in the components. contextTypes, getChildContext, getInitialState and componentWillReceiveProps to name a few.

We could merge them in a Mixin but seemingly React is moving away from mixins. The alternative solution is to use a high-order component. Or maybe require context to always be exposed by a root component like it was before? (This would also solve #1926)

Thoughts?
louy referenced this issue Oct 20, 2015
@louy
Full RTL Support
5212f0d
@alitaheri alitaheri added this to the ES6 Classes milestone Dec 9, 2015
@alitaheri alitaheri added the Core label Dec 9, 2015
@alitaheri
Copy link
Member

Almost same as #458

mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@dependabot-preview
Bump rollup from 2.10.2 to 2.18.1 (mui#1941)
6a09d98 
Bumps [rollup](https://github.com/rollup/rollup) from 2.10.2 to 2.18.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.10.2...v2.18.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@zannager zannager added core Infrastructure work going on behind the scenes customization: css Design CSS customizability labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes customization: css Design CSS customizability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@louy @alitaheri @zannager