Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Date Picker] Year selection is broken #2010

Closed
mgibeau opened this issue Oct 29, 2015 · 8 comments
Closed

[Date Picker] Year selection is broken #2010

mgibeau opened this issue Oct 29, 2015 · 8 comments
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!

Comments

@mgibeau
Copy link
Contributor

mgibeau commented Oct 29, 2015

Trying to select a year from the date picker throws an error, using version 0.13.
Uncaught TypeError: Cannot read property 'isSelectedDateDisabled' of undefined

Can be reproduced on:
http://material-ui.com/#/components/date-picker

On the other hand, it seems to work fine if you click the month after selecting the year.

@oliviertassinari
Copy link
Member

This is a regression introduced by my latest PR to improve perf on the date picker.
This is the line responsible from the error https://github.com/callemall/material-ui/blob/master/src/date-picker/date-picker-dialog.jsx#L146. I don't understand what isSelectedDateDisabled is for. Same for _selectedDateDisabled that was introduced by f8bdaf3. @jkruder Any idea?

@Reggino
Copy link

Reggino commented Nov 29, 2015

+1
Broken for a month now?

@oliviertassinari
Copy link
Member

Well, yes, it's still broken, we need better unit test for the datepicker.

@genyded
Copy link

genyded commented Dec 5, 2015

+7 for this and fixing this and with a large # of values. Some of us are trying to get apps into production using this stuff

@oliviertassinari
Copy link
Member

I agree, this should be a priority.

@oliviertassinari
Copy link
Member

This should be fixed on the master branch, sorry for this long response time!

@bpmckee
Copy link

bpmckee commented Dec 17, 2015

@oliviertassinari Any idea how long it will take to get this into 0.14.0? using 0.14.0-rc1 in order to get around some other broken things in x.13.x.

@oliviertassinari
Copy link
Member

We should have kept a 0.13.x to release hot fixes, but we didn't.
I hope that we can release 0.14 before the end of the year. We are doing heavy changes with this up coming release.

mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
Bumps [@types/fs-extra](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/fs-extra) from 8.1.0 to 9.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/fs-extra)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@zannager zannager added component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

6 participants