-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] Missing Material Design icons #21295
Comments
@twltwl It looks like Google has added some new icons, so the package needs a fresh build. |
@twltwl Do you want to work on it? :) yarn
cd packages/material-ui-icons
rm legacy/CastForEducation.js
rm legacy/CastForEducationOutlined.js
rm legacy/CastForEducationRounded.js
rm legacy/CastForEducationSharp.js
rm legacy/CastForEducationTwoTone.js
rm legacy/StarRate.js
rm legacy/StarRateOutlined.js
rm legacy/StarRateRounded.js
rm legacy/StarRateSharp.js
rm legacy/StarRateTwoTone.js
yarn src:download
yarn src:icons
git commit -am "[icons] Synchronize icons with Google" |
cd ../..
yarn docs:icons ? |
@mbrookes Right, we would also need to look at the synonyms for the search on the documentation. I can already see one 😆 https://material.io/resources/icons/?search=wash&icon=wash&style=baseline |
@oliviertassinari @mbrookes I can take this, but wanted to check with you on one thing. The new dump of icons from Google no longer contains the "Motorcycle" icon that is currently being used in the production package (it only contains "TwoWheeler" with a synonym "motorcycle"). Should it be moved to the |
@alecananian Thanks for looking into it. I can understand why Google removed the motocycle icon, the icon itself isn't their best work and has a narrower use case. Adding a synonym would be great. I'm leaning towards adding a fallback but that re export the two wheeler icon with a message that ask users to change the import. |
Landed here because I'm not seeing the icons "pending" and "pending_actions". |
Nor the pull request linked directly above your comment apparently. 😉 |
@mbrookes My apologies; I should have just thumbed up the OP and left it at that. Didn't mean to irritate. |
Not irritated, just couldn't resist 😁 |
The SupportAgent (https://material.io/resources/icons/?icon=support_agent) icon does not seem to be avaible in @material-ui/icons 4.9.1
Current Behavior 😯
import SupportAgentIcon from '@material-ui/icons/supportAgent' Module not found: Can't resolve '@material-ui/icons/supportAgent' or import { SupportAgent } from '@material-ui/icons' Attempted import error: 'SupportAgent' is not exported from '@material-ui/icons'
Expected Behavior 🤔
The icon should be imported
Steps to Reproduce 🕹
https://codesandbox.io/s/xenodochial-rubin-5jerc?fontsize=14&hidenavigation=1&theme=dark
Your Environment 🌎
The text was updated successfully, but these errors were encountered: