Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Missing Material Design icons #21295

Closed
2 tasks done
twltwl opened this issue Jun 3, 2020 · 11 comments · Fixed by #21498
Closed
2 tasks done

[icons] Missing Material Design icons #21295

twltwl opened this issue Jun 3, 2020 · 11 comments · Fixed by #21498
Labels
new feature New feature or request package: icons Specific to @mui/icons ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@twltwl
Copy link

twltwl commented Jun 3, 2020

The SupportAgent (https://material.io/resources/icons/?icon=support_agent) icon does not seem to be avaible in @material-ui/icons 4.9.1

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

import SupportAgentIcon from '@material-ui/icons/supportAgent' Module not found: Can't resolve '@material-ui/icons/supportAgent' or import { SupportAgent } from '@material-ui/icons' Attempted import error: 'SupportAgent' is not exported from '@material-ui/icons'

Expected Behavior 🤔

The icon should be imported

Steps to Reproduce 🕹

https://codesandbox.io/s/xenodochial-rubin-5jerc?fontsize=14&hidenavigation=1&theme=dark

Your Environment 🌎

Tech Version
Material-UI v4.10.1
Material-UI-Icons v4.9.1
@twltwl twltwl added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 3, 2020
@mbrookes mbrookes added new feature New feature or request package: icons Specific to @mui/icons and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 3, 2020
@mbrookes
Copy link
Member

mbrookes commented Jun 3, 2020

@twltwl It looks like Google has added some new icons, so the package needs a fresh build.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 3, 2020

@twltwl Do you want to work on it? :)

yarn
cd packages/material-ui-icons
rm legacy/CastForEducation.js
rm legacy/CastForEducationOutlined.js
rm legacy/CastForEducationRounded.js
rm legacy/CastForEducationSharp.js
rm legacy/CastForEducationTwoTone.js
rm legacy/StarRate.js
rm legacy/StarRateOutlined.js
rm legacy/StarRateRounded.js
rm legacy/StarRateSharp.js
rm legacy/StarRateTwoTone.js
yarn src:download
yarn src:icons
git commit -am "[icons] Synchronize icons with Google"

@oliviertassinari oliviertassinari added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Jun 3, 2020
@oliviertassinari oliviertassinari changed the title SupportAgent icon is missing [icons] Missing Material Design icons Jun 3, 2020
@mbrookes
Copy link
Member

mbrookes commented Jun 3, 2020

cd ../..
yarn docs:icons

?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 3, 2020

@mbrookes Right, we would also need to look at the synonyms for the search on the documentation. I can already see one 😆 https://material.io/resources/icons/?search=wash&icon=wash&style=baseline

@alecananian
Copy link
Contributor

@oliviertassinari @mbrookes I can take this, but wanted to check with you on one thing. The new dump of icons from Google no longer contains the "Motorcycle" icon that is currently being used in the production package (it only contains "TwoWheeler" with a synonym "motorcycle"). Should it be moved to the legacy folder to avoid a breaking change?

@oliviertassinari
Copy link
Member

@alecananian Thanks for looking into it. I can understand why Google removed the motocycle icon, the icon itself isn't their best work and has a narrower use case. Adding a synonym would be great. I'm leaning towards adding a fallback but that re export the two wheeler icon with a message that ask users to change the import.

@Kizmar
Copy link

Kizmar commented Jun 18, 2020

Landed here because I'm not seeing the icons "pending" and "pending_actions".

@oliviertassinari
Copy link
Member

@Kizmar it will be solved in #21498.

@mbrookes
Copy link
Member

Landed here because I'm not seeing the icons "pending" and "pending_actions".

Nor the pull request linked directly above your comment apparently. 😉

@Kizmar
Copy link

Kizmar commented Jun 18, 2020

@mbrookes My apologies; I should have just thumbed up the OP and left it at that. Didn't mean to irritate.

@mbrookes
Copy link
Member

Not irritated, just couldn't resist 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: icons Specific to @mui/icons ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants