-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] Synchronize icons with Google #21498
Conversation
Details of bundle changes.Comparing: daa1810...4fb30c4 Details of page changes
|
Great work! We're missing a synonym "5g' for the |
3c4e828
to
71727d6
Compare
@alecananian I have rebased the pull request on the |
Thanks for the updates! @mbrookes I've gone ahead and added those synonyms now as well. |
…mui#21457)" This reverts commit 34958a6.
This reverts commit e21536c.
Change 1,100 to 1,300 and tweak the wording.
Change 1,100 to 1,300 and tweak the wording.
db4ff9b
to
428dee1
Compare
The publishing script seems to systematically fail. I suspect the new icons makes us reach a timeout. There are too many of them. |
Is that the
|
Not sure, I have seen the same fail in other pull requests. However, it could be interesting to reduce the number of published files on the package, if it turns to be a bottleneck. |
Five "themes" per component, or separate package per "theme"? |
@mbrookes A package per theme could be interesting, especially to scale to themes outside material design.
They might be another leverage, force 1 level deep imports, drop the |
I encounter this in my own packages as well that have even less files than |
@alecananian Thanks! |
If I'm not mistaken the icons have been included in the new v5 release, but still aren't in v4. Is it not planned now to include them in v4 anymore? @oliviertassinari wrote this in the latest v4 release notes:
As v5 is still in alpha, that means the missing icons won't be available for production for quite a long time? Not the end of the world as you can include them yourself, but still 😢 |
@fabyeah Your analysis and conclusion are correct. You will have to choose what you want most. Note that we do our best to keep the master and next branch in a state that allows us to ship a release at any time. The main downside of relying on v5.0.0-alpha.1 are the breaking changes that we will land. |
Closes #21295
Icons have been newly synced with Google, adding 200+ to the mix. A few notes: