Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws when using browserify and not reactify #215

Closed
asgerhallas opened this issue Jan 8, 2015 · 3 comments · May be fixed by javifelices/material-ui#6 or javifelices/material-ui#11
Closed

Throws when using browserify and not reactify #215

asgerhallas opened this issue Jan 8, 2015 · 3 comments · May be fixed by javifelices/material-ui#6 or javifelices/material-ui#11
Labels
core Infrastructure work going on behind the scenes

Comments

@asgerhallas
Copy link

Seems like:

"browserify": {
    "transform": [
      [
        "reactify",
        {
          "es6": true
        }
      ]
    ]
  }

in material.ui's package.json makes browserify fail, if reactify is not installed in the application that uses material-ui.

The error is:

Error: Cannot find module 'reactify' from 'c:\workspace\client\node_modules\material-ui'

Work around is obviously to just install reactify regardless, but thought you might want to know :)

@troutowicz
Copy link
Contributor

material-ui contains several .jsx files that need compiling to .js, reactify handles that transformation.

@asgerhallas
Copy link
Author

Yes, it can do that, but I do my transformations beforehand and run browserify on pure .js files after. It's just that this config-entry is a little intrusive as to how I choose to build :)

Couldn't the config be a something the hosting application specifies?
Or if Reactify really ought to be installed in the application hosting material-ui (even if it's not used), shouldn't it be listed as a peer dependency?

@hai-cea
Copy link
Member

hai-cea commented Feb 10, 2015

This will be resolved once #179 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
5 participants