-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Move typography inside the theme #2908
Comments
I think it's best to move typography inside theme. It's more robust and easier to customize. |
I agree 💯 |
Hi @oliviertassinari @alitaheri @newoga. i'm planning to move typography inside theme as I have done in my previous PR so right now I have found card component that needs it. So it would be great if you guys can provide me a list that needs this change. |
@heetvachhani I just added the list to the description of the issue at the top. Good luck! 😄 |
great thanks @newoga 👍 |
Thanks a lot @heetvachhani 👍 |
Can we close this one? @newoga |
I think so, I think you did them all @heetvachhani! Thanks! |
I think it would be helpful to include a page on this including a demonstration of the different font weights, colors and how different tags render by default. Might be a good exercise to learn how we might want to expand typography in the future as mentioned in (#1915, #1789, #2422).
What do you think?
@oliviertassinari @alitaheri @mbrookes
Notes:
Current components that import from Typography.
The text was updated successfully, but these errors were encountered: