Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Move typography inside the theme #2908

Closed
7 tasks done
newoga opened this issue Jan 12, 2016 · 8 comments
Closed
7 tasks done

[Doc] Move typography inside the theme #2908

newoga opened this issue Jan 12, 2016 · 8 comments
Labels
discussion docs Improvements or additions to the documentation umbrella For grouping multiple issues to provide a holistic view

Comments

@newoga
Copy link
Contributor

newoga commented Jan 12, 2016

I think it would be helpful to include a page on this including a demonstration of the different font weights, colors and how different tags render by default. Might be a good exercise to learn how we might want to expand typography in the future as mentioned in (#1915, #1789, #2422).

What do you think?
@oliviertassinari @alitaheri @mbrookes

Notes:
Current components that import from Typography.

  • AppBar
  • Badge
  • CardHeader
  • CardMedia
  • FlatButton
  • RaisedButton
  • Subheader
@newoga newoga added docs Improvements or additions to the documentation discussion labels Jan 12, 2016
@alitaheri
Copy link
Member

I think it's best to move typography inside theme. It's more robust and easier to customize.

@oliviertassinari
Copy link
Member

I think it's best to move typography inside theme. It's more robust and easier to customize.

I agree 💯

@heetvachhani
Copy link
Contributor

Hi @oliviertassinari @alitaheri @newoga. i'm planning to move typography inside theme as I have done in my previous PR so right now I have found card component that needs it. So it would be great if you guys can provide me a list that needs this change.

@newoga
Copy link
Contributor Author

newoga commented Feb 11, 2016

@heetvachhani I just added the list to the description of the issue at the top. Good luck! 😄

@heetvachhani
Copy link
Contributor

great thanks @newoga 👍

@alitaheri alitaheri added the umbrella For grouping multiple issues to provide a holistic view label Feb 11, 2016
@alitaheri alitaheri changed the title [Doc] Current typography options [Doc] Move typography inside the theme Feb 11, 2016
@alitaheri
Copy link
Member

Thanks a lot @heetvachhani 👍

@heetvachhani
Copy link
Contributor

Can we close this one? @newoga

@newoga
Copy link
Contributor Author

newoga commented Mar 8, 2016

I think so, I think you did them all @heetvachhani! Thanks!

@newoga newoga closed this as completed Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion docs Improvements or additions to the documentation umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

No branches or pull requests

4 participants