[Core] Typography moved inside muitheme

[heetvachhani]

Reference to #2908

[newoga]

BTW, this can also be written like this:

const {
  fontSize,
  fontWeight,
} = this.state.muiTheme.flatButton;

[heetvachhani]

should I update this change @newoga?

[newoga]

Might be okay for now, what do you think @oliviertassinari @alitaheri?

If the the theme changes are solid, I'm good merging this as is. I think for this file we'll have to revisit to removing ContextPure and getRelevantContextKeys. That might be a good opportunity to reorganize the assignment of theme variables.

[alitaheri]

We'll have to revisit all the files again. so this is alright in my book 😁

[newoga]

Thanks @heetvachhani, good work!

[heetvachhani]

okay not a problem. You're welcome @newoga 😄

[alitaheri]

This is really lovely 😍 Thanks a lot @heetvachhani

All green on ly end 👍

[oliviertassinari]

@heetvachhani Thanks! Can we deprecate the Typography file now and close #2908?

[heetvachhani]

@oliviertassinari so what I have to do for that?
You're welcome @alitaheri @oliviertassinari

[oliviertassinari]

Can we deprecate the Typography file now

Actually, that may not be a good idea. That make sense to keep it, as for the colors.

[newoga]

Actually, that's may not be a good idea. That make sense to keep it as for the colors.

Yeah I was wondering the same. Let's hold off, sometimes I wonder if material-ui could still use some tooling to help developers implement some of the ideas discussed here in the spec.

@heetvachhani
Do you want to do the same thing you did in this PR but do it for ./Colors. A number of components directly import directly from colors and color manipulator, there might be opportunities to use theme variables for that as well.

[heetvachhani]

yes sure I can do that. @newoga. Just give me the list of components and will do it.

[alitaheri]

@heetvachhani You can get the list and the exact position from my PR:
#2825

I can't merge that because it breaks the docs. but if you remove all the usage of colors from these files I can merge that PR too. 2 birds with 1 stone 😍 😍

[heetvachhani]

Thanks @alitaheri it will make my work easy . cool 2 birds with 1 "arrow" 😄