Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] does not comply to material design #3393

Closed
jma7889 opened this issue Feb 20, 2016 · 3 comments
Closed

[Slider] does not comply to material design #3393

jma7889 opened this issue Feb 20, 2016 · 3 comments
Labels
component: slider This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process

Comments

@jma7889
Copy link

jma7889 commented Feb 20, 2016

  1. Description and slider are not in the same line, description is always above the slider. While in the material design spec, description and slider can be above or on the left side of slider.
  2. No support to put text value on either end of slider. In fact, slider seem always occupy a line, cannot put text on either end. If it supports it, please add example to show how.
  3. No support for discrete slider.
@alitaheri alitaheri added the design: material This is about Material Design, please involve a visual or UX designer in the process label Feb 20, 2016
@newoga newoga changed the title Slider does not comply to material design [Slider] does not comply to material design Mar 9, 2016
@rsteckler
Copy link

I would add that the implementation is inconsistent with the other "form" elements. Toggle, for example, has the descriptor on the left, and it's bold. Slider has the descriptor on the line above and it's not bold. This makes designing a form problematic.

@ashl1
Copy link

ashl1 commented Oct 3, 2016

@rsteckler The MUI guys are right in that. Check the GMD specification: https://material.google.com/components/sliders.html#sliders-continuous-slider The title should be on the line above.

@oliviertassinari oliviertassinari added the component: slider This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari
Copy link
Member

We plan on migrating the component to the v1-beta branch. I'm closing the issue for #4793.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

No branches or pull requests

5 participants