Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactify missing as dependency #344

Closed
0x80 opened this issue Feb 17, 2015 · 7 comments · Fixed by #391
Closed

Reactify missing as dependency #344

0x80 opened this issue Feb 17, 2015 · 7 comments · Fixed by #391
Labels
docs Improvements or additions to the documentation

Comments

@0x80
Copy link

0x80 commented Feb 17, 2015

Not sure if this one can be blamed on material-ui at all. If I use browserify on material-ui, and I don't have reactify installed I get this error:

Running "browserify:vendor" (browserify) task
>> Error: ENOTDIR, stat '/Users/me/myproject/node_modules/material-ui/node_modules/react-draggable2/index.js/node_modules/reactify'

I'm not using reactify myself since I replaced it with 6to5ify/babelify. Shouldn't the reactify module be installed as a dependency of react-draggable2?

@luisrudge
Copy link
Contributor

yeah. I'm having this problem too.

@shadowmint
Copy link

+1, having this issue too.

You can work around it by not depending on index.js and instead on specific sub components that don't use react-draggable2, but it's annoying.

@weijarz
Copy link

weijarz commented Mar 4, 2015

+1
work around it by install reactify on project level.

@ranweiler
Copy link

+1
I'm using the same workaround as @weijar. The dependencies of react-draggable2 just need adjustment. I've opened an issue upstream (mikepb/react-draggable#2), along with a PR to fix it (mikepb/react-draggable#3).

@mikepb
Copy link
Contributor

mikepb commented Mar 4, 2015

Commit mikepb/react-draggable@9d31268 removes the dependency on reactify for browserify users by pre-compiling react-draggable. Please let me know if that fixes things (I'm not a browserify user).

Note: the change has not been pushed to NPM or material-ui, but is available for testing.

@fourcube
Copy link

fourcube commented Mar 5, 2015

+1

@ranweiler
Copy link

Thanks to @mikepb, this is fixed for me if material-ui simply updates its dependency on react-draggable2 to ^0.5.0, which is now in NPM.

hai-cea pushed a commit that referenced this issue Mar 6, 2015
Update react-draggable2 dependency #344
brianfeister pushed a commit to brianfeister/material-ui that referenced this issue May 1, 2017
* Updated CSP for nonce backwards compatibility

* Documented

* Updates comments
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants