-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LeftNav doesn't play with iOS fullscreen mode #366
Comments
Reproduced this in Phonegap. It looks like it's the onTouchTap function: I can't reproduce the behavior if I use onClick instead. My code for reference: menuItems = [
{route: '/foo', text: 'Foo'}
{route: '/bar', text: 'Bar'}
]
App = React.createClass
toggleMenu: ->
@refs.nav.toggle()
closeIfOpen: ->
if @refs.nav.state.open
@refs.nav.close()
render: ->
div {onTouchTap: @closeIfOpen},
(UI.LeftNav {menuItems, docked: false, ref: 'nav'}),
(UI.RaisedButton {label: 'Default', onTouchTap: @toggleMenu}) |
Okay, well I figured out my problem. So, I had added the @0x80 if you have something like that in your code, maybe that's the problem. |
I have no idea what changed in my app, but I can't reproduce it anymore. The LeftNav seems to be working ok for me now. |
I am able to consistently reproduce this problem, both in a webview using Cordova, and using the "Add to Home Screen" feature.
The problem is that a menu item reacts to a click event which happens after the nav is opened. |
Fixes mui#366. The problem is that the click event is fired *after* left-nav opens. We're safe though if we just replace it with onTouchTap.
<meta name="apple-mobile-web-app-capable" content="yes">
This meta tag would allow iOS to display the app in fullscreen after using the "add to homescreen" feature in Safari. I found that by doing this I can't use the LeftNav component anymore, because it closes immediately after opening. I'm not able to hit any or the menu links.
The text was updated successfully, but these errors were encountered: