Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Second level nested menu can't be clicked #3818

Closed
mbrookes opened this issue Mar 27, 2016 · 3 comments · Fixed by #3947
Closed

[Menu] Second level nested menu can't be clicked #3818

mbrookes opened this issue Mar 27, 2016 · 3 comments · Fixed by #3947
Labels
bug 🐛 Something doesn't work
Milestone
0.15.0 Release

Comments

@mbrookes
Copy link
Member

Problem Description

The second (or subsequent) level nested menu can't be reached. On clicking to open the second level submenu, the first sub menu closes, causing the second to alo close.

Can be seen on docs site Nested menu example.

screen cap

Versions

  • Material-UI: HEAD @45734e5 (Works in 0.14.4)
  • React: Any
  • Browser: Test in Chrome 49.
@mbrookes mbrookes added this to the 0.15.0 Release milestone Mar 27, 2016
@nathanmarks
Copy link
Member

Confirmed in multiple browsers btw

@nathanmarks nathanmarks added the bug 🐛 Something doesn't work label Mar 28, 2016
@nathanmarks
Copy link
Member

@newoga @oliviertassinari

You guys mind taking a quick look at this? I narrowed it down to this commit: 6878200 from pr #3360

newoga added a commit to newoga/material-ui that referenced this issue Apr 12, 2016
@newoga
[Menu] Fix nested menus that can't be clicked issue
d9878fd 
This fixes a regression that was introduced in mui#3360. The previous `click-awayable` mixin listened on `mouseup` and `touchend` events and the new `ClickAwayListener` was implemented to use `mousedown` and `touchstart` events. This commit changes the events to mimick the behavior from the original mixin.

Resolves mui#3818
This was referenced Apr 12, 2016
Merged
Closed
oliviertassinari added a commit that referenced this issue Apr 18, 2016
@oliviertassinari
Merge pull request #3947 from newoga/fix/#3818
f2bae01 
[Menu] Fix nested menus that can't be clicked issue
aahan96 pushed a commit to aahan96/material-ui that referenced this issue Apr 19, 2016
@newoga @aahan96
[Menu] Fix nested menus that can't be clicked issue
296a4eb 
This fixes a regression that was introduced in mui#3360. The previous `click-awayable` mixin listened on `mouseup` and `touchend` events and the new `ClickAwayListener` was implemented to use `mousedown` and `touchstart` events. This commit changes the events to mimick the behavior from the original mixin.

Resolves mui#3818
und3fined pushed a commit to und3fined/material-ui that referenced this issue Apr 20, 2016
@newoga
[Menu] Fix nested menus that can't be clicked issue
806ad5f 
This fixes a regression that was introduced in mui#3360. The previous `click-awayable` mixin listened on `mouseup` and `touchend` events and the new `ClickAwayListener` was implemented to use `mousedown` and `touchstart` events. This commit changes the events to mimick the behavior from the original mixin.

Resolves mui#3818
tintin1343 pushed a commit to tintin1343/material-ui that referenced this issue Apr 25, 2016
@newoga @tintin1343
[Menu] Fix nested menus that can't be clicked issue
8e565f0 
This fixes a regression that was introduced in mui#3360. The previous `click-awayable` mixin listened on `mouseup` and `touchend` events and the new `ClickAwayListener` was implemented to use `mousedown` and `touchstart` events. This commit changes the events to mimick the behavior from the original mixin.

Resolves mui#3818
@kavimaluskam
Copy link

I just experienced the same issue with material-ui@0.18.1 with react@15.4.2.
Mind to check if this is my special case or the issue appears again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
0.15.0 Release
Development

Successfully merging a pull request may close this issue.

[Menu] Fix nested menus that can't be clicked issue newoga/material-ui
3 participants
@mbrookes @nathanmarks @kavimaluskam