[TablePagination][material-ui] Type error for hiddenLabel prop in SelectProps

[MonstraG]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Steps to reproduce 🕹

Link to live example:
https://codesandbox.io/s/pensive-bardeen-2kq5g6?file=/src/App.tsx

Current behavior 😯

Typescript error

No overload matches this call.
  Overload 1 of 2, '(props: { component: "div"; } & TablePaginationBaseProps & { ActionsComponent?: ElementType<TablePaginationActionsProps>; ... 15 more ...; sx?: SxProps<...>; } & CommonProps & Omit<...>): Element', gave the following error.
    Type '{ variant: "filled"; size: "small"; hiddenLabel: true; disableUnderline: true; }' is not assignable to type 'Partial<SelectProps<unknown>>'.
      Object literal may only specify known properties, and 'hiddenLabel' does not exist in type 'Partial<SelectProps<unknown>>'.
  Overload 2 of 2, '(props: DefaultComponentProps<TablePaginationTypeMap<{}, JSXElementConstructor<TablePaginationBaseProps>>>): Element', gave the following error.
    Type '{ variant: "filled"; size: "small"; hiddenLabel: true; disableUnderline: true; }' is not assignable to type 'Partial<SelectProps<unknown>>'.
      Object literal may only specify known properties, and 'hiddenLabel' does not exist in type 'Partial<SelectProps<unknown>>'.ts(2769)

But hiddenLabel works

Expected behavior 🤔

Everything works without errors

Context 🔦

Workaround:

SelectProps={
	{
		variant: "filled",
		size: "small",
		hiddenLabel: true,
		disableUnderline: true
	} as Omit<FilledInputProps, "onChange">
}

Your environment 🌎

See live link

[MonstraG]

On related note, size in TablePagination seems to not do anything.

[ZeeshanTamboli]

@MonstraG Thanks for flagging the problem. It's indeed a bug.

The issue lies for the SelectProps prop used by TablePagination, which uses the Select component's TypeScript types. To resolve this, we can apply prop types on the Select component based on the chosen variant, similar to what we did for TextField in this pull request: #36737.

[PaulKristoffersson]

I can take a look at this issue.

[ZeeshanTamboli]

@PaulKristoffersson Feel free to create a PR.