[TextField] Improve IntelliSense support for props #36737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-36737--material-ui.netlify.app/ Bundle size report |
This comment was marked as outdated.
This comment was marked as outdated.
1 task
sai6855
commented
Apr 17, 2023
| @@ -11,6 +11,22 @@ import { expectType } from '@mui/types'; | |||
| <TextField variant="standard" InputProps={{ classes: { inputTypeSearch: 'search-input' } }} /> | |||
| ); | |||
|
|
|||
| const StandardInputAdorned = ( | |||
sai6855
commented
Apr 17, 2023
ZeeshanTamboli
approved these changes
Apr 18, 2023
ZeeshanTamboli
approved these changes
Apr 19, 2023
michaldudak
reviewed
Apr 27, 2023
sai6855
force-pushed
the
textfield-typescript
branch
from
aa24cff
to
954ab7c
Compare
ZeeshanTamboli
changed the title
|
Michał didn't find any issues in his review, so it is ready to merge. Looks good to me as well. |
2 tasks
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36232
closes #36862
Description for #36232 :
From trial & error, i got to know Intellisense is not extracting description when type is
union typeand forconditional typeintellisense is able to correctly extract info.Since existing tests from this file has enough coverage, i haven't added any tests.
Before for #36232:
AFTER for #36232:
working code sandbox for #36232 : https://codesandbox.io/s/peaceful-rosalind-purnu8?file=/demo.tsx
before codesandbox for #36862 : https://codesandbox.io/s/infallible-haibt-ytenql?file=/styles.css:0-38
after codesandbox for #36862: https://codesandbox.io/s/goofy-leavitt-428poo?file=/demo.tsx