Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Deprecate composed CSS classes #41282

Open
12 of 30 tasks
DiegoAndai opened this issue Feb 26, 2024 · 9 comments
Open
12 of 30 tasks

[material-ui] Deprecate composed CSS classes #41282

DiegoAndai opened this issue Feb 26, 2024 · 9 comments
Assignees
Labels
deprecation New deprecation message package: material-ui Specific to @mui/material ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Feb 26, 2024

Part of #40417

Description

Deprecate composed CSS classes, which are planned for removal in v7.

  • These are deprecated in favor of using atomic classes and combining them in userland
  • If the atomic classes do not exist, they must be implemented in the same PR in which the deprecation is added
  • The PR introducing the deprecation must also add:

Example PR

Contributing

Feel free to take any components that still need to be done or in progress. Please mention this issue in your PR so we can link it in the description and keep it up to date.

Components to migrate

  • AccordionSummary: #40418, #41006
  • Alert: #40688
  • Button: #40675
  • ButtonGroup: #41259
  • Chip: #41235
  • CircularProgress: #42076
  • Dialog
  • Divider: #40563
  • Drawer
  • FilledInput
  • ImageListItemBar: #42905
  • Input
  • InputBase
  • LinearProgress
  • LoadingButton
  • NativeSelect
  • OutlinedInput
  • PaginationItem: #40673, #41145
  • Select: #42950
  • Slider
  • SpeedDial
  • SpeedDialAction
  • SpeedDialIcon
  • StepConnector: #41740
  • SwipeableDrawer
  • TableSortLabel: #42281
  • TabList
  • Tabs
  • ToggleButtonGroup: #41288
  • Tooltip

Search keywords: deprecation composed classes material-ui

Search keywords:

@harry-whorlow
Copy link
Contributor

Hi @DiegoAndai,

I would like to help out with this task, I'm thinking of starting with tooltip, but I'm having a little difficulty discerning the composed classes from the atomic ones. I'm looking at the docs docs,
would I be correct in assuming that the merge request should look something along the lines of:

.MuiTooltip-arrow
.MuiTooltip-popper
.MuiTooltip-popperArrow [deprecated]
.MuiTooltip-popperClose [deprecated]
.MuiTooltip-popperInteractive [deprecated]
.MuiTooltip-tooltip
.MuiTooltip-tooltipArrow
.MuiTooltip-tooltipPlacementBottom [deprecated]
.MuiTooltip-tooltipPlacementLeft [deprecated]
.MuiTooltip-tooltipPlacementRight [deprecated]
.MuiTooltip-tooltipPlacementTop [deprecated]
.MuiTooltip-touch

Where the composed classes are the the joins of what would be individual css classes applied to the children.

@DiegoAndai
Copy link
Member Author

Hi @harry-whorlow! The Tooltip components is a complex component, I'm not sure what the best class structure would be best 🤔

I would suggest starting with the SpeedDial component.

@harry-whorlow
Copy link
Contributor

harry-whorlow commented Jun 27, 2024

Copy that, I'll start with the old friend SpeedDial 🫡

[edit]: I've had a lot of things come up, if someone wants to take over go ahead. I'll update this comment if something changes in the future. Sorry

@alisasanib
Copy link
Contributor

Hi @DiegoAndai

I would like to help out with this task. Is it still available for contribution from the community?

@yash49
Copy link
Contributor

yash49 commented Oct 30, 2024

Hello @DiegoAndai, I would like to contribute as well.
Which of the remaining components would you recommend?

@DiegoAndai
Copy link
Member Author

Hey @alisasanib @yash49, thanks for reaching out, and sorry for the delay. Any of the components in the description's list that don't have a PR attached are free to take. I would recommend starting with simpler components like the LinearProgress or SpeedDial. Let me know if you will be taking any of these. Thanks in advance!

@harry-whorlow
Copy link
Contributor

harry-whorlow commented Dec 27, 2024

If it's alright with you, I'll start with speed dial as it was the PR I was working on before the endeavour was paused.

@yash49
Copy link
Contributor

yash49 commented Dec 27, 2024

@DiegoAndai I'll work on Drawer

@yash49
Copy link
Contributor

yash49 commented Dec 27, 2024

Hi @DiegoAndai
please review #44870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation New deprecation message package: material-ui Specific to @mui/material ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
Status: In progress
Development

No branches or pull requests

4 participants