Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Drawer] Deprecate composed classes #44870

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[material-ui][Drawer] Deprecate composed classes #44870

wants to merge 3 commits into from

Conversation

yash49
Copy link
Contributor

@yash49 yash49 commented Dec 27, 2024 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Dec 27, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ccebcdd

@yash49 yash49 force-pushed the depracate-drawer-classes branch from 085151b to 846dfdc Compare December 27, 2024 21:51
@yash49 yash49 marked this pull request as ready for review December 27, 2024 22:01
@yash49 yash49 mentioned this pull request Dec 27, 2024
Open
30 tasks
@yash49
Copy link
Contributor Author

yash49 commented Dec 27, 2024

I observed that SwipeableDrawer uses .MuiDrawer-<...> classes
instead of .MuiSwipeableDrawer-<...> classes

but the docs mention that it uses .MuiSwipeableDrawer-<...> classes

Question to maintainers -

  1. SwipeableDrawer was affected by this PR
    Do I have to make any other changes for SwipeableDrawer

  2. Also is there a way to fix this ?
    image
    SwipeableDrawer class is deprecated but combined Drawer classes should be used instead?

@yash49
Copy link
Contributor Author

yash49 commented Dec 27, 2024

  1. Do we need any tests for new MuiDrawer-anchor<Direction> classes ?

@zannager zannager added the component: drawer This is the name of the generic UI component, not the React module! label Dec 30, 2024
@zannager zannager requested a review from DiegoAndai December 30, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: drawer This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash49 @mui-bot @zannager