Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] not getting correct dimensions if is display: none on initial render #415

Closed
omerts opened this issue Mar 10, 2015 · 3 comments
Closed

[Menu] not getting correct dimensions if is display: none on initial render #415

omerts opened this issue Mar 10, 2015 · 3 comments
Labels
bug 🐛 Something doesn't work
Milestone
0.14.0 Release

Comments

@omerts
Copy link
Contributor

omerts commented Mar 10, 2015

Hello,

I am using the Menu element, but after the first render the menu is hidden using display:none.
After the component mounts, you are setting the this._initialMenuHeight, which is 0 at this point, and it never changes.
@yhbrandon
Copy link

css override maybe? I too have encountered this, but typically force the width with less/css

@omerts
Copy link
Contributor Author

omerts commented Mar 11, 2015

I think the menu's height and width, should be dynamic, will also solve problem with dynamic menu items

@hai-cea hai-cea changed the title Menu not getting correct dimensions if is display: none on initial render [Menu] not getting correct dimensions if is display: none on initial render Jun 18, 2015
@alitaheri alitaheri added the bug 🐛 Something doesn't work label Dec 8, 2015
@alitaheri alitaheri modified the milestone: 0.14.0 Release Dec 9, 2015
@alitaheri
Copy link
Member

Menu is now a simple component thanks to Popover.

brianfeister pushed a commit to brianfeister/material-ui that referenced this issue May 1, 2017
@ctrlplusb
Windows (mui#415)
1f26e01 
* update eslintrc line-breaks for windows

* add prop-types as a dependency to prevent react-hot-loader from breaking build.
add cross-env for starting tasks which break on Windows.
add FAQ for when running develop and javascript files aren't loading even though the build is successful.
modify the clean task to execute a function rather than use the ${npm bin} exec command, which doesnst work on Windows.

* save exact package.json

* add cross-env to npm scripts
@akashmitra akashmitra mentioned this issue Nov 4, 2022
Open
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
@hzhz hzhz mentioned this issue Nov 5, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this issue Nov 5, 2022
Open
@akashmitra akashmitra mentioned this issue Dec 25, 2022
Open
@maniator maniator mentioned this issue Dec 26, 2022
Open
@hzhz hzhz mentioned this issue Dec 26, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this issue Dec 26, 2022
Open
@ryan-ally ryan-ally mentioned this issue Nov 27, 2023
Open
@ryan-ally ryan-ally mentioned this issue May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
0.14.0 Release
Development

No branches or pull requests
3 participants
@yhbrandon @omerts @alitaheri