-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joy UI: Disabled Link IconButton appearance appears to still be enabled #43245
Comments
Yes @BSoDium , there is no disable attribute on |
I totally agree with you on the fact that an Plus, it is a bit misleading to leave the disabled prop available to the user if it is not intended to be used in this specific case, isn't it? If you are not planning on handling it any time soon, what clean solution would you recommend to palliate to this? |
@BSoDium Yes it's a bug, I will try to fix it and raise a PR for the same. Also if it's urgent for you then try to add some style on the button to disable it. Something like |
I'll experiment with this, greatly appreciate the reactivity, thank you for the help! |
Thanks for reporting the issue! Joy UI development is temporarily on hold as the maintainers focus on the next two major releases of Material UI |
Are you guys still reviewing and accepting PRs? Or is everything fully on hold? |
This breaks the visual equivalence with the current Joy UI icon button component, but allows the `disabled` property to be used in the same way as the button component. Related issue: mui/material-ui#43245
Steps to reproduce
Link to live example: https://codesandbox.io/s/peaceful-estrela-dr8zfz
Steps:
"a"
orLink
fromreact-router-dom
disabled
prop totrue
Current behavior
The button appears to still be enabled even though it shouldn't be.
Expected behavior
The button should be disabled (no pointer-events, less contrast with the background, etc...)
Context
I am simply trying to have a link button be disabled.
My guess: in the DOM, the disabled prop cannot be applied to the
a
element, which messes up the styles since the selector is literally:Your environment
Tested on Chrome version 127.0.6533.89 (Official Build) (arm64)
npx @mui/envinfo
Search keywords: IconButton, disabled, Link, react-router-dom, enabled
The text was updated successfully, but these errors were encountered: