Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material-UI button component shows click/tap animation twice on iPhone 5, 5s, 6 on iOS8 #456

Closed
jdinard opened this issue Mar 23, 2015 · 5 comments · Fixed by #599
Closed

Material-UI button component shows click/tap animation twice on iPhone 5, 5s, 6 on iOS8 #456

jdinard opened this issue Mar 23, 2015 · 5 comments · Fixed by #599
Labels
component: button This is the name of the generic UI component, not the React module! mobile Targets mobile platform

Comments

@jdinard
Copy link

jdinard commented Mar 23, 2015

Not a major issue, but the animation gets shown twice on all of the iPhones I've tested on.

iPhone 5, 5s and 6, all running iOS8
@huchenme
Copy link

same for me, and for the ripple show up on any touch event, by right should be only tap event

@troutowicz
Copy link
Contributor

I experience this on iOS8 as well.

@pomerantsev
Copy link
Contributor

I haven't seen this issue when I posted #542, which is essentially a duplicate of this one. It is fixed in #543, so this issue can be closed.

@huchenme
Copy link

@pomerantsev I think it is not pushed to npm yet, how can I use the latest version? is that now the ripple will be response to "tap" only? previously the ripple response to any touch event, even when you are scrolling

pomerantsev added a commit to pomerantsev/material-ui that referenced this issue Apr 30, 2015
@pomerantsev
Use a different approach for preventing ghost click ripples
e38c9cd 
Resolves mui#456.
@pomerantsev pomerantsev mentioned this issue Apr 30, 2015
Merged
@pomerantsev
Copy link
Contributor

@huchenme, looks like I never actually tested the patch on iOS. The new patch should fix the issue.
And no, the "ripple on scroll" behavior hasn't changed.

@akashmitra akashmitra mentioned this issue Nov 4, 2022
Open
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
@hzhz hzhz mentioned this issue Nov 5, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this issue Nov 5, 2022
Open
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@akashmitra akashmitra mentioned this issue Dec 25, 2022
Open
@maniator maniator mentioned this issue Dec 26, 2022
Open
@hzhz hzhz mentioned this issue Dec 26, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this issue Dec 26, 2022
Open
@zannager zannager added component: button This is the name of the generic UI component, not the React module! mobile Targets mobile platform and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! mobile Targets mobile platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a different approach for preventing ghost click ripples pomerantsev/material-ui
6 participants
@jdinard @huchenme @oliviertassinari @pomerantsev @troutowicz @zannager