-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
Open
Labels
scope: iconsChanges related to the icons.Changes related to the icons.
Description
Summary
Removing the data-testid from icons only for production is very confusing because if you run e2e tests with the production version, as we do, you might have your tests running locally when implementing them, because you use the dev version, but have them fail on CI that uses the prod version. If you forget about this point you might have to wait for the CI to finish to figure out the issue. This also makes debugging very difficult unless you're aware of this subtlety.
Is it possible to add some flag/env var to opt out of removing the data-testid?
Related PR.
Examples
No response
Motivation
No response
Search keywords: icons, testid, data-testid
nicobatalla, khitrenovich, NickR49, jnaO, OskarAsplin-cf and 23 more
Metadata
Metadata
Assignees
Labels
scope: iconsChanges related to the icons.Changes related to the icons.