Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable selectall problem #5234

Closed
qiang123 opened this issue Sep 22, 2016 · 1 comment
Closed

Datatable selectall problem #5234

qiang123 opened this issue Sep 22, 2016 · 1 comment
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!

Comments

@qiang123
Copy link

Table 'select all' does not worked as expected, when I click select all, then deselect all, will leave one row selected.

Versions

  • Material-UI: 0.15.4

I just use http://www.material-ui.com/#/components/table do the test.

select all

image

deselect all

image
vividh added a commit to vividh/material-ui that referenced this issue Sep 24, 2016
@vividh
[Table] Fix deselect all logic
3c6ac57 
Remove logic where last TableRow was selected when deselecting all
items.
Fixes mui#5234.
@vividh vividh mentioned this issue Sep 24, 2016
Closed
3 tasks
@lucasbento lucasbento added bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! labels Oct 15, 2016
@lucasbento
Copy link

hey @qiang123, thank you for reporting this!

We are building another table from the ground up on the next branch, so, this will be fixed soon.

@ovaldi ovaldi mentioned this issue Dec 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qiang123 @lucasbento