Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Numeric value label on discrete slider #5558

Closed
llopez95 opened this issue Nov 15, 2016 · 6 comments
Closed

[Slider] Numeric value label on discrete slider #5558

llopez95 opened this issue Nov 15, 2016 · 6 comments
Labels
component: slider This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@llopez95
Copy link

Problem description

I figured out that it was possible to create a "discrete slider" with the 'min', 'max' and 'step' props but it seems not possible to display a numeric value label on it.

However the material specs specify it well here :
https://material.google.com/components/sliders.html#sliders-discrete-slider

Could this feature be integrated in a near future ?

Thanks !

Versions

  • Material-UI: ^0.16.0
  • React: ^15.0.0
  • Browser:
@oliviertassinari oliviertassinari added component: slider This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists labels Nov 15, 2016
@oliviertassinari
Copy link
Member

I'm closing this issue for #5383.

Could this feature be integrated in a near future?

I'm not aware that anyone is working on it.

@tariqwest
Copy link

@llopez95 I put together this quick solution, may be helpful for you. Considering developing it further... https://github.com/tariqwest/material-ui-slider-label

@oliviertassinari
Copy link
Member

@tariqwest That looks really great! Would you be interested in migrating the Slider to the next branch?

@oliviertassinari
Copy link
Member

Also, we could add a link toward that lib in our documentation. We already have quite a few libraries extending Material-UI.

@tariqwest
Copy link

@oliviertassinari Yeah! I would actually be interested in migrating Slider to Next branch. This library's been really useful to me and would be glad to contribute something back.

And yes please feel free to add link to my quick fix extension - I'm in process of making that extension less brittle and conform better to google design and behaviors.

@oliviertassinari
Copy link
Member

@tariqwest Done with a0ab405. We have the following issue #4793 to track the progress on the rewrite on the next branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants