-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Port component #4793
Comments
Can anyone estimate when this component will be available on v1? |
@oliviertassinari can you let us know if there are any plans for this to be implemented please? The implication here is that there aren't any. If so, can you just confirm because I'll need to implement a different one. It seems only the slider is missing from beta? |
I have the same problem. We decided to use material ui beta and only this component is missing. If you don't start with it until end of next week, then I think I will try to implement it because it will block us :) |
You can use something like rc-slider in the mean time. We will most likely release v1 without this component, it will come later. |
Because material-ui v1 doesn't provide the component for now mui/material-ui#4793
@oliviertassinari Why the decision to not put the slider to 1.0? |
@uwap It's a matter of time constraints, first, we focus on the core components. Then, step by step, we increase the supported list of components. I don't think that being in v1.0 or v1.1 is relevant. It's more a matter of when. |
@uwap as the author of The first release of the current beta has to have at least version |
I started working on migrating this component myself a couple days ago, will make a PR soon. |
@itsDizzy Let us know about your progress :). I would highly encourage you to benchmark the other implementations available out there. For instance, SVGOMG version looks good. |
@oliviertassinari you should check out this slider component concept I've been working on. Leaves all the opinionated stuff to the user like styles and markup. Just give it a MUI Rail, Track and Handle components (ticks, too, if you want them). Still a WIP: https://github.com/sghall/react-compound-slider Docs in the repo is a MUI beta app (your old docs app) if you want to give it a whirl. |
I wrote a slider starting last Friday. It's mostly done, but not yet public yet. Has the following features:
I'm a bit busy, trying to finish up the port of my client site from 0.20 to 1.0, so can't release this just yet. But the plan is to do so within the week. |
@eigood Look forward to seeing it. Since it sounds like your primary use-case is video, are you using the progress bar for the track? This provides the buffering animation and read-ahead bar: |
I use this slider for the video scrubber, for volume control, and for selecting which of 48 pregenerated thumbnails. The slider is fully designed to be used outside of video; the SS was from the test page I had. What is holding me up, is that I haven't released stuff in the node ecosystem before, and nothing in the es6 era, so I don't yet know the community standard way of doing a standalone project. For instance, I really don't like having to pre-build a library for use by downstreams, I'd rather just assume my users would have a proper compiler. |
@eigood - Any update on the slider? I'm using material-ui-next but using material-ui-slider-label gives me an error because it's looking for muiTheme in this.context and for whatever reason I get the error - I'm assuming it's something to do with differences between material-ui and material-ui-next. |
@eigood You should definitely be transpiling your ES6 source for the release version, although some libraries include the es6 source in the released package. You could take a look at packages/lab for inspiration, although that's slightly complicated by the fact that we're sharing dev dependencies with the parent. |
Any updates about migrating Slider to the "Next" version? We really like to use Material for all controls and waiting Slider as well :) |
@eigood this is the guide/example that I've been following in my ES6 libraries: https://github.com/kriasoft/babel-starter-kit |
Any update on this one? :) |
Here's a solution for making form of multiple sliders or even one single slider with event handler passed For more we can check HTML input Range and CSS provided by CSS-Tricks This solution working perfectly with me ;) Using codeSandbox |
Is there any ETA on this component? |
No. But you can start using it under the lab package. You can expect breaking changes until it's moved to the core. |
Any update on this component? |
@forthrightstl see Slider. You can already use it from |
are there plans to support multiple values? |
@joseph-allen Not currently. |
For those of you hunting for a good slider to use (permanently or in the mean time) we found this library to be really wonderful and easy to work with. https://github.com/sghall/react-compound-slider |
The text was updated successfully, but these errors were encountered: