Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoprefixer produces values that fail tests #7264

Closed
djbuckley opened this issue Jun 27, 2017 · 1 comment
Closed

Autoprefixer produces values that fail tests #7264

djbuckley opened this issue Jun 27, 2017 · 1 comment
Labels
bug 🐛 Something doesn't work

Comments

@djbuckley
Copy link

The values produced by utils/autoprefixer fail the unit tests as the inline style prefixer has been updated to produce correct values.

After running an npm update and then rerunning the tests, the following output is produced :

 1) ./utils/autoprefixer server side should spread properties for display:flex when userAgent is all:
 
      AssertionError: expected { Object (display) } to deeply equal { Object (display) }
      + expected - actual
 
       {
      -  "display": "-webkit-inline-box; display: -moz-inline-box; display: -ms-inline-flexbox; display: -webkit-inline-flex; display: inline-flex"
      +  "display": "-webkit-box; display: -moz-box; display: -ms-inline-flexbox; display: -webkit-inline-flex; display: inline-flex"
       }
 
      at Function.assert.deepEqual (node_modules\chai\lib\chai\interface\assert.js:216:32)
      at Context. (src/utils/autoprefixer.spec.js:36:14)

 
Line 37 in autoprefixer.spec.js expects :
display: '-webkit-box; display: -moz-box; display: -ms-inline-flexbox; display: -webkit-inline-flex; display: inline-flex', // eslint-disable-line max-len
this won't work due to the following issue : robinweser/inline-style-prefixer#132 (basically the author had it outputting incorrect values, that nobody had noticed, so its now correct).

updating this to
display: '-webkit-inline-box; display: -moz-inline-box; display: -ms-inline-flexbox; display: -webkit-inline-flex; display: inline-flex', // eslint-disable-line max-len
will resolve the failing test

@oliviertassinari
Copy link
Member

Sounds like we would be better off with yarn. Do you want to submit a PR to upgrade our dependency and fix the failing test? :)

djbuckley added a commit to djbuckley/material-ui that referenced this issue Jun 27, 2017
djbuckley added a commit to djbuckley/material-ui that referenced this issue Jun 27, 2017
update to correct issues detailed in mui#7264
oliviertassinari pushed a commit that referenced this issue Jun 27, 2017
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jun 27, 2017
chowdream added a commit to chowdream/Material-UI that referenced this issue Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

2 participants