Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Add SelectDisplayProps prop #10408

Merged
merged 7 commits into from
Feb 23, 2018
Merged

[Select] Add SelectDisplayProps prop #10408

merged 7 commits into from
Feb 23, 2018

Conversation

noah-potter
Copy link
Contributor

@noah-potter noah-potter commented Feb 22, 2018 •
edited
Loading

Closes #10401

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 22, 2018
@noah-potter
Copy link
Contributor Author

noah-potter commented Feb 23, 2018 •
edited
Loading

Is this error something I can resolve? It's not entirely clear what the error is.

@mbrookes
Copy link
Member

@noah-potter run yarn docs:api or npm run docs:api

oliviertassinari
oliviertassinari previously requested changes Feb 23, 2018
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one concern with exposing the SelectDisplayProps property to the top Select component. It's boilerplate the native implementation might not need. What about scoping the change to the SelectInput component waiting for the component to be split with #10335?

src/Select/SelectInput.js Outdated
@@ -154,6 +154,7 @@ class SelectInput extends React.Component {
open: openProp,
readOnly,
renderValue,
SelectDisplayProps = {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the default.

@noah-potter
Copy link
Contributor Author

@oliviertassinari Should that scoping happen whenever SelectInput is split? I'm not sure how to make this change anticipate the two SelectInputs

@oliviertassinari oliviertassinari added new feature New feature or request component: select This is the name of the generic UI component, not the React module! and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 23, 2018
@oliviertassinari
Copy link
Member

I think that the simplest path to solve #10335 is to introduce a NativeSelect component, sharing some code with Select.

@oliviertassinari oliviertassinari self-assigned this Feb 23, 2018
@oliviertassinari oliviertassinari merged commit abd6cfc into mui:v1-beta Feb 23, 2018
@nikoskleidis nikoskleidis mentioned this pull request Feb 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

Assignees

@oliviertassinari oliviertassinari

Labels
component: select This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noah-potter @mbrookes @oliviertassinari