Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card] Expandable CardText #1060

Merged
merged 6 commits into from
Jul 16, 2015
Merged

[Card] Expandable CardText #1060

merged 6 commits into from
Jul 16, 2015

Conversation

cgestes
Copy link
Contributor

@cgestes cgestes commented Jul 8, 2015

@cgestes cgestes force-pushed the card-expandable branch from 656ba82 to 5d3c97a Compare July 8, 2015 08:22
hai-cea
hai-cea reviewed Jul 8, 2015
View reviewed changes
docs/src/app/components/pages/components/cards.jsx
name: 'expandable',
type: 'bool',
header: 'optional',
desc: 'Wether this card has expandable contents.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here - 'Whether'

@cgestes cgestes force-pushed the card-expandable branch from 5d3c97a to 3d22269 Compare July 8, 2015 16:05
@cgestes
Copy link
Contributor Author

cgestes commented Jul 8, 2015

refactored.

items with expandable={true} will be toggled.
items with expandableController={true} will have an additional child CardExpandable to control the expansion.

better idea welcome...

Would it be a good idea to have something similar for nested list item? (currently if the child is not a ListItem but a component that render a ListItem nested list does not work).

@cgestes cgestes force-pushed the card-expandable branch 5 times, most recently from 2bfb299 to ef28af1 Compare July 10, 2015 07:57
@cgestes
Copy link
Contributor Author

cgestes commented Jul 13, 2015

Hi @hai-cea

What should we do with this changeset?

Do you think it follows md guideline enough or should it be more restricted?

@hai-cea
Copy link
Member

hai-cea commented Jul 13, 2015

@cgestes I think it's good. Here's some more feedback:

  1. We should use a different icon - please see:
    image
  2. Do you think we should rename the expandableController prop to showExpandableButton?
  3. I think the example is a little confusing. I was expecting the top level icon button to expand and collapse the whole card?

@cgestes
Copy link
Contributor Author

cgestes commented Jul 16, 2015

Hi,

pushed a new batch of commits.

Hope everything is addressed now.

  • renamed expandableController prop to showExpandableButton
  • changed the icons (really sorry for that)
  • updated the example to be more simple and what most people will wants

@hai-cea
Copy link
Member

hai-cea commented Jul 16, 2015

Looks great - Thanks @cgestes 👍

hai-cea pushed a commit that referenced this pull request Jul 16, 2015
Merge pull request #1060 from cgestes/card-expandable
58b239a 
[Card] Expandable CardText
@hai-cea hai-cea merged commit 58b239a into mui:master Jul 16, 2015
@cgestes
Copy link
Contributor Author

cgestes commented Jul 16, 2015

cool, thank you.

@cgestes cgestes deleted the card-expandable branch July 16, 2015 17:28
@zannager zannager added the component: card This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: card This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgestes @hai-cea @zannager