Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Change the default spacing value: 0 #10768

Merged
merged 2 commits into from
Mar 22, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 22, 2018

Closes #10223

Breaking change

The negative margin implementation solution currently used comes with serious limitations.
Material-UI is the only library with a non-zero default spacing between the items.
Having zero spacing by default will ease the usage of the component.

-<Grid />
+<Grid spacing={16} />

@oliviertassinari oliviertassinari merged commit b8aa5f2 into mui:v1-beta Mar 22, 2018
@oliviertassinari oliviertassinari deleted the grid-spacing-0 branch March 22, 2018 23:19
@oliviertassinari oliviertassinari changed the title [Grid] Change default spacing value: 0 [Grid] Change the default spacing value: 0 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant