Enable transparency manipulation #10958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into trouble when manipulating colors across themes. I use the same primary color(deepOrange) for my light and dark themes, but when trying to blend them with their respective backgrounds it looked messy and required unnecessary coloring logic. Following the same philosophy of lighten/darken, opacify allows blending the palette with the rest of the theme in a simple manner, e.g.: opacify(lighten(theme.palette.primary.light, 0.75), 0.2).
|
Don't forget that |
|
Am I missing something, or is this not just a copy / paste / rename of |
oliviertassinari
added
the
PR: needs revision
I confirm. It's the 💯% the same logic. One more good reason to document these helpers. @luminaxster A pull request is welcomed :). |
|
Oh man, fade went through me when I saw it. Thank you, guys! |
|
Yeah, sorry, the name isn't the most intuitive, but it was like that when I found it. 😁 If we're going to document them, now might be the time to rationalise the naming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into trouble when manipulating colors across themes. I use the same primary color(deepOrange) for my light and dark themes, but when trying to blend them with their respective backgrounds it looked messy and required unnecessary coloring logic. Following the same philosophy of lighten/darken, opacify allows blending the palette with the rest of the theme in a simple manner, e.g.: opacify(lighten(theme.palette.primary.light, 0.75), 0.2).