-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] Constrain props type param appropriately in withStyles, withTheme, withWidth HOCs #11003
Commits on Apr 12, 2018
-
Rewrite withStyles definition, using Omit
My experience is that the current `withStyles` declaration works poorly with Typescript 2.8. I'm not sure that it's the compiler version that's the issue, though. At least in my usage, it fails to remove `WithStyles<ClassKey>` from the return type. This definition works better in my experience, doesn't rely on subtle inferencer behavior in the same way, and seems to be in the mainstream of current usage. There's a built-in `Exclude` function in Typescript 2.8 that does what `Omit` does. I used `Omit` for compatibility with older compilers.
Configuration menu - View commit details
-
Copy full SHA for e1f809d - Browse repository at this point
Copy the full SHA e1f809dView commit details -
Fix test issues; redesign withTheme, withWidth using Omit also.
estaub committedApr 12, 2018 Configuration menu - View commit details
-
Copy full SHA for f488adf - Browse repository at this point
Copy the full SHA f488adfView commit details
Commits on Apr 13, 2018
-
estaub committed
Apr 13, 2018 Configuration menu - View commit details
-
Copy full SHA for 3560ac0 - Browse repository at this point
Copy the full SHA 3560ac0View commit details -
Remove another inferrable generic parameter from test.
estaub committedApr 13, 2018 Configuration menu - View commit details
-
Copy full SHA for 8eb517a - Browse repository at this point
Copy the full SHA 8eb517aView commit details
Commits on Apr 14, 2018
-
Remove another inferrable generic parameter from test.
estaub committedApr 14, 2018 Configuration menu - View commit details
-
Copy full SHA for 175fa49 - Browse repository at this point
Copy the full SHA 175fa49View commit details -
Make inclusion of WithStyles in the innerComponent's type def optional.
estaub committedApr 14, 2018 Configuration menu - View commit details
-
Copy full SHA for 92bee1b - Browse repository at this point
Copy the full SHA 92bee1bView commit details
Commits on Apr 16, 2018
-
Commit for review and suggestions; DOES NOT COMPILE.
Remove commented-on code from withStyles; use ConsistentWith typewrapper; add SFC test for withWidth add FAILING test for doc scenario 2 (withStyles of union)
estaub committedApr 16, 2018 Configuration menu - View commit details
-
Copy full SHA for c01d787 - Browse repository at this point
Copy the full SHA c01d787View commit details -
Redefine with* to remove Omit.
Trim obsolete doc. Rename "decorate" function to "withMyStyles" in doc. Remove redundant failing tests added to clarify Omit problem.
estaub committedApr 16, 2018 Configuration menu - View commit details
-
Copy full SHA for 89d2a60 - Browse repository at this point
Copy the full SHA 89d2a60View commit details -
Bring back explicit generic parameter on union case in test, doc.
In package.json, up-rev Typescript to >2.6.2, and print Typescript version in "typescript" run command.
estaub committedApr 16, 2018 Configuration menu - View commit details
-
Copy full SHA for bcbf701 - Browse repository at this point
Copy the full SHA bcbf701View commit details -
Rename withMyStyles back to decorate.
Use single quotes in test. In package.json, revert typescript to 2.6.1, remove version-printing run command In package.lock, revert typescript to 2.6.1.
estaub committedApr 16, 2018 Configuration menu - View commit details
-
Copy full SHA for 9fbbbc1 - Browse repository at this point
Copy the full SHA 9fbbbc1View commit details
Commits on Apr 17, 2018
-
Add trailing comma to function params in styling-comparison test.
estaub committedApr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for e66b8ea - Browse repository at this point
Copy the full SHA e66b8eaView commit details -
estaub committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 0b47fb3 - Browse repository at this point
Copy the full SHA 0b47fb3View commit details -
Remove newline from typescript doc.
estaub committedApr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 748af39 - Browse repository at this point
Copy the full SHA 748af39View commit details -
estaub committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for b24250b - Browse repository at this point
Copy the full SHA b24250bView commit details -
Remove extra explicit from doc, add trailing semicolon to function
estaub committedApr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for ac934c1 - Browse repository at this point
Copy the full SHA ac934c1View commit details -
Merge branch 'v1-beta' of https://github.com/mui-org/material-ui into…
… patch-1
estaub committedApr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for f1dbf16 - Browse repository at this point
Copy the full SHA f1dbf16View commit details -
Remove comment from styling-comparison.spec.tsx
estaub committedApr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for ea20df9 - Browse repository at this point
Copy the full SHA ea20df9View commit details