Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WithStylesOptions extend the options argument of createStyleSheet #11325

Merged
merged 6 commits into from
May 12, 2018
Merged

Make WithStylesOptions extend the options argument of createStyleSheet #11325

merged 6 commits into from
May 12, 2018

Conversation

pelotom
Copy link
Member

@pelotom pelotom commented May 10, 2018 •
edited
Loading

Fixes #11312

@pelotom pelotom merged commit 84d0ff2 into mui:v1-beta May 12, 2018
@pelotom pelotom deleted the fix-25692 branch May 12, 2018 18:04
oliviertassinari pushed a commit to oliviertassinari/material-ui that referenced this pull request May 12, 2018
@pelotom @oliviertassinari
Make WithStylesOptions extend the options argument of createStyleSheet (
51ecd64 
mui#11325)

* Make WithStylesOptions extend the options argument of createStyleSheet (fixes mui#25692)

* Use CreateStyleSheetOptions from JSS

* Provide a type param default for backwards compatibility

* Fix issue link in comment

* Fix lockfile

* Resolve all @types/jss to 9.5.3
@macdoni02 macdoni02 mentioned this pull request Apr 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pelotom @oliviertassinari