-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs] Allow tabs to be controlled or uncontrolled - Fixes #1186 #1166
Conversation
@Zadielerick Please use |
@jkruder Sorry, I had included a ton of other commits that I did not want in the last PR and figured it was faster to remove it rather than try to update and fix all the merge conflicts it had. When I did do git rebase, the merge conflicts would not stop popping up each time i fixed them, so it was just simpler to make a new updated branch and push the changes |
@jkruder Hey, so I completely forgot to push the branch, that seemed to be the problem after I would rebase, now it works, thanks so much :) |
@Zadielerick No problem. Glad you were able to figure it out. If you have any questions let us know! |
629e459
to
c6fd1d0
Compare
bedf316
to
182869c
Compare
@hai-cea What do you think? Also is the documentation ok? |
c79a2dd
to
7a85b67
Compare
69ac61a
to
7360f5c
Compare
Replaced by #1232 |
Allows you to toggle whether none of the tabs are selected.