Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Allow tabs to be controlled or uncontrolled - Fixes #1186 #1166

Closed
wants to merge 1 commit into from

Conversation

Zadielerick
Copy link
Contributor

Allows you to toggle whether none of the tabs are selected.

@jkruder
Copy link
Contributor

jkruder commented Jul 15, 2015

@Zadielerick Please use git rebase master from your working branch instead of opening and closing tickets in the future. This will also isolate your changes so that only your changes appear in the PR. This is extremely helpful when we are trying to evaluate the PR. After you have done a rebase you will need to do a ``git push origin {your branch here} --force` if you have already pushed your branch (there may be other ways but I found this to be the most direct). This command will force your remote branch to update.

@Zadielerick
Copy link
Contributor Author

@jkruder Sorry, I had included a ton of other commits that I did not want in the last PR and figured it was faster to remove it rather than try to update and fix all the merge conflicts it had. When I did do git rebase, the merge conflicts would not stop popping up each time i fixed them, so it was just simpler to make a new updated branch and push the changes

@Zadielerick
Copy link
Contributor Author

@jkruder Hey, so I completely forgot to push the branch, that seemed to be the problem after I would rebase, now it works, thanks so much :)

@jkruder
Copy link
Contributor

jkruder commented Jul 16, 2015

@Zadielerick No problem. Glad you were able to figure it out. If you have any questions let us know!

@Zadielerick Zadielerick force-pushed the TabsProp branch 2 times, most recently from 629e459 to c6fd1d0 Compare July 16, 2015 17:22
@hai-cea hai-cea changed the title [Tabs] Unselected Prop [Tabs] Allow tabs to be controlled or uncontrolled - Fixes #1186 Jul 16, 2015
@Zadielerick Zadielerick force-pushed the TabsProp branch 7 times, most recently from bedf316 to 182869c Compare July 17, 2015 19:07
@Zadielerick
Copy link
Contributor Author

@hai-cea What do you think? Also is the documentation ok?

@hai-cea
Copy link
Member

hai-cea commented Jul 21, 2015

Replaced by #1232

@hai-cea hai-cea closed this Jul 21, 2015
@Zadielerick Zadielerick deleted the TabsProp branch July 23, 2015 21:01
@zannager zannager added the component: tabs This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants