Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Property !== attribute #11694

Merged

Conversation

adeelibr
Copy link
Contributor

@adeelibr adeelibr commented Jun 3, 2018

Closes #11427

@oliviertassinari
Copy link
Member

I don't get it. What's the point of this pull-request? Shouldn't we aim to keep the examples as simple as possible? I doubt this use case is generatic enough to be added into the documentation, maybe into some StackOverflow issue.

@adeelibr
Copy link
Contributor Author

adeelibr commented Jun 3, 2018

Can you guide me just a little bit as to what it is that i should add in this pr? More explanation for the inputRef prop or something else.. @oliviertassinari

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 3, 2018

Following #11427 (comment), I think that we should apply the following diff:

-Properties applied to the native input element.
+Attributes applied to the native input element.

as well as to all the other relevant occurrences.

The property vs attribute is an advanced topic. Most people shouldn't have to worry about, and the one that do, should already know the difference, so I think that no more effort is needed.

@adeelibr
Copy link
Contributor Author

adeelibr commented Jun 3, 2018

Okay understood 👍

This was my small 4th PR, any feedback for me so far sir? Where can I be more helpful working on docs or code, anything that i should improve on? @oliviertassinari

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI docs Improvements or additions to the documentation labels Jun 4, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 4, 2018

In the specific context of HTML / Javascript the HTML representation of a DOM element has attributes but when represented as a JavaScript object those attributes appear as object properties.

What is the difference between attribute and property?

@oliviertassinari oliviertassinari changed the title added inputRef example in text-field doc [docs] Property !== attribute Jun 4, 2018
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jun 4, 2018
@oliviertassinari oliviertassinari merged commit 0e4814f into mui:master Jun 4, 2018
@adeelibr
Copy link
Contributor Author

adeelibr commented Jun 4, 2018

Sorry for the late delay at my end, I was going to do it! I'll try to be more prompt next time.

@oliviertassinari
Copy link
Member

@adeelibr Oh sorry, next time :)

acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
* added inputRef example in text-field doc

* [core] Property !== attribute
@adeelibr adeelibr deleted the text-field-documenation-update-input-ref branch May 30, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants