-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Property !== attribute #11694
[docs] Property !== attribute #11694
Conversation
I don't get it. What's the point of this pull-request? Shouldn't we aim to keep the examples as simple as possible? I doubt this use case is generatic enough to be added into the documentation, maybe into some StackOverflow issue. |
Can you guide me just a little bit as to what it is that i should add in this pr? More explanation for the inputRef prop or something else.. @oliviertassinari |
Following #11427 (comment), I think that we should apply the following diff: -Properties applied to the native input element.
+Attributes applied to the native input element. as well as to all the other relevant occurrences. The property vs attribute is an advanced topic. Most people shouldn't have to worry about, and the one that do, should already know the difference, so I think that no more effort is needed. |
Okay understood 👍 This was my small 4th PR, any feedback for me so far sir? Where can I be more helpful working on docs or code, anything that i should improve on? @oliviertassinari |
|
Sorry for the late delay at my end, I was going to do it! I'll try to be more prompt next time. |
@adeelibr Oh sorry, next time :) |
* added inputRef example in text-field doc * [core] Property !== attribute
Closes #11427