Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CircularProgress] Fix centering #11781

Merged
merged 2 commits into from
Jun 8, 2018
Merged

[CircularProgress] Fix centering #11781

merged 2 commits into from
Jun 8, 2018

Conversation

adeelibr
Copy link
Contributor

@adeelibr adeelibr commented Jun 8, 2018 •
edited by oliviertassinari
Loading

Closes #11761

@adeelibr adeelibr mentioned this pull request Jun 8, 2018
Closed
2 tasks
@oliviertassinari oliviertassinari changed the title bug fixed [CircularProgress] Fix midpoint centering Jun 8, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: CircularProgress The React component labels Jun 8, 2018
@oliviertassinari oliviertassinari changed the title [CircularProgress] Fix midpoint centering [CircularProgress] Fix centering Jun 8, 2018
@oliviertassinari oliviertassinari merged commit 1004ede into mui:master Jun 8, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 8, 2018 •
edited
Loading

@adeelibr Thanks for picking up the "good first issue" tag. It's your 4th pull-requests.
Maybe it's time to move to some harder issues, keeping the "good first issue" issues aside so we can use them to onboard new users :).

@adeelibr
Copy link
Contributor Author

adeelibr commented Jun 8, 2018

@oliviertassinari Okay :D sounds great. What kind of issues should I tackle apart from "good first issue" issues ? Can you give me something challenging.

@oliviertassinari
Copy link
Member

What kind of issues should I tackle apart from "good first issue" issues

@adeelibr It's up to you. It doesn't even have to be an open issue for it. I'm personally working on the problems I face using Material-UI on a real project or on what I think is important for the growth of Material-UI.

acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
@adeelibr
[CircularProgress] Fix centering (mui#11781)
e480f6f 
* bug fixed

* add comment
@adeelibr adeelibr deleted the feature-circular-progress-line-height branch May 30, 2019 11:24
@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircularProgress animation's midpoint is off when (size / line-height) <= ~10
2 participants
@adeelibr @oliviertassinari