-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update ts example #11949
[docs] Update ts example #11949
Conversation
@@ -1,5 +1,6 @@ | |||
{ | |||
"compilerOptions": { | |||
"baseUrl": ".", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without it there are a few warnings that flash on startup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the warnings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin │
Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, ok 🤷♂️
Thanks! |
* ass baseUrl to avoid startup warning * update withStyles syntax
To avoid issues with
withStyles
and Typescript as discussed here: #11109 (comment)cc @pelotom