Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update ts example #11949

Merged
merged 2 commits into from
Jun 22, 2018
Merged

[docs] Update ts example #11949

merged 2 commits into from
Jun 22, 2018

Conversation

kevinhughes27
Copy link
Contributor

To avoid issues with withStyles and Typescript as discussed here: #11109 (comment)

cc @pelotom

@@ -1,5 +1,6 @@
{
"compilerOptions": {
"baseUrl": ".",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it there are a few warnings that flash on startup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the warnings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin                              │                                                                                                           
Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, ok 🤷‍♂️

@pelotom pelotom merged commit 3604774 into mui:master Jun 22, 2018
@pelotom
Copy link
Member

pelotom commented Jun 22, 2018

Thanks!

@oliviertassinari oliviertassinari added typescript docs Improvements or additions to the documentation labels Jun 22, 2018
@oliviertassinari oliviertassinari changed the title Update ts example [docs] Update ts example Jun 26, 2018
acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
* ass baseUrl to avoid startup warning

* update withStyles syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants