Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Warn when the first argument is wrong #11953

Merged
merged 1 commit into from
Jun 22, 2018
Merged

[styles] Warn when the first argument is wrong #11953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/pages/customization/css-in-js/css-in-js.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ For instance, it can be used to defined a `getInitialProps()` static method (nex

#### Arguments

1. `styles` (*Function | Object*): A function generating the styles or an object.
1. `styles` (*Function | Object*): A function generating the styles or a styles object.
It will be linked to the component.
Use the function signature if you need to have access to the theme. It's provided as the first argument.
2. `options` (*Object* [optional]):
Expand Down
8 changes: 8 additions & 0 deletions packages/material-ui/src/styles/getStylesCreator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ function arrayMerge(destination, source) {
function getStylesCreator(stylesOrCreator) {
const themingEnabled = typeof stylesOrCreator === 'function';

warning(
typeof stylesOrCreator === 'object' || themingEnabled,
[
'Material-UI: the first argument provided to withStyles() is invalid.',
'You need to provide a function generating the styles or a styles object.',
].join('\n'),
);

function create(theme, name) {
const styles = themingEnabled ? stylesOrCreator(theme) : stylesOrCreator;

Expand Down