[docs] Add a demo with Font Awesome #12027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Jul 1, 2018
oliviertassinari
commented
oliviertassinari
force-pushed
the
icon-font-awesome
branch
from
be29a1b
to
2d40f4c
Compare
oliviertassinari
force-pushed
the
icon-font-awesome
branch
from
2d40f4c
to
0a77838
Compare
oliviertassinari
force-pushed
the
icon-font-awesome
branch
from
0a77838
to
9fbdf21
Compare
|
Hi, thx for this Demo! You could also check out react-fontawesome, they provide a more "react-way" for using fontawesome in react-apps. You could have a look at my Demo, where I included your example, your example where I just changed the components and one example implemented without the I think this approach is a bit clener than loading the CSS :-) |
acroyear
pushed a commit
to acroyear/material-ui
that referenced
this pull request
Jul 14, 2018
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.