Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Remove FiberManualRecord fill attribute #12102

Closed
wants to merge 1 commit into from
Closed

[Icons] Remove FiberManualRecord fill attribute #12102

wants to merge 1 commit into from

Conversation

ChristiaanScheermeijer
Copy link
Contributor

The fill attribute prevents us from changing the fill using CSS/JSS.

@ChristiaanScheermeijer
Copy link
Contributor Author

After doing a quick search, I've found the following icons are also using a fill attribute. Is this intended?

  • ArtTrack
  • ArrowDownward
  • NextWeek
  • ScatterPlot
  • Spa (different color)
  • StrikeThroughS

@oliviertassinari
Copy link
Member

@ChristiaanScheermeijer This file is automatically generated. You can't edit it directly.

@ChristiaanScheermeijer
Copy link
Contributor Author

ah, I see... Do you have suggestions how we can change/fix this for the above icons? 🙂

@por
Copy link

por commented Jul 11, 2018

@ChristiaanScheermeijer here probably https://github.com/mui-org/material-ui/blob/master/packages/material-ui-icons/builder.js

@ChristiaanScheermeijer
Copy link
Contributor Author

New PR: #12111

@zannager zannager added the package: icons Specific to @mui/icons label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: icons Specific to @mui/icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristiaanScheermeijer @oliviertassinari @por @zannager